Add an error dialog when we fail to parse settings #903
Conversation
* Load messages from the Resources.resw file
* Display a message when we fail to parse the settings on an initial parse, or
on a reload.
* Unfortunately, the dialog is styled incorrectly when the app theme is
opposite the system theme. This can result in the button being invisible.
…or-dialog # Conflicts: # src/cascadia/CascadiaPackage/Resources/en-US/Resources.resw
zadjii-msft
added
Area-User Interface
| <value>Ok</value> | ||
| </data> | ||
| <data name="ReloadJsonParseErrorText" xml:space="preserve"> | ||
| <value>Settings could not be reloaded from file. Check for syntax errors, including trailing commas.</value> |
There was a problem hiding this comment.
Is there space, time or brainpower to surface the exception text?
Will the exception text be useful or interesting?
There was a problem hiding this comment.
We could always make it a follow-up task to investigate
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
|
From #748
Make sure that keybindings serialization pops the error dialog correctly too |
# Conflicts: # src/cascadia/TerminalApp/App.cpp
ghost
added
the
Needs-Author-Feedback
|
Will this dialog (and other error, confirmatory or feedback dialogs) be using a UWP ContentDialog, MessageDialog, or a Win32 MessageBox? I vote for UWP (eventually WinUI 3.0) dialogs. |
|
@mdtauk The screenshot looks exactly like a win32 MessageBoxW i think |
ghost
removed
the
Needs-Author-Feedback
|
@DHowett-MSFT Things I'm excited to see land: |
Summary of the Pull Request
Add an error dialog when we fail to parse settings.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Sneak peek:
ContentDialogdoes a weird thing where it takes its child and moves that to the popup and leaves itself in the tree. That causes things likeElementThemeinheritance to break. So instead, we're theming theCloseButtonmanually, to make sure it's always visible.