Link to WinMM.Lib for PlaySound with 19041 #9624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PlaySound functions were removed from OneCoreUAP_apiset.Lib in Windows 10 SDK 19041 because they did not actually belong there. Link to WinMM.Lib for PlaySoundW.
zadjii-msft
approved these changes
Mar 26, 2021
zadjii-msft
added
Area-CodeHealth
miniksa
approved these changes
Mar 26, 2021
DHowett
approved these changes
Mar 26, 2021
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
Sounds good, happy to change this. Did you mean common.build.post.props, which includes OneCoreUAP_apiset.Lib? |
|
Oop, yeah. You don't need to fix this one, honestly. We have enough link line chicanery going on already that having these few additional entries isn't more cognitive burden than before. |
DHowett
pushed a commit
that referenced
this pull request
Mar 26, 2021
The PlaySound functions were removed from OneCoreUAP_apiset.Lib in Windows 10 SDK 19041 because they did not actually belong there. Link to WinMM.Lib for PlaySoundW. ### Validation Steps Performed * Built for x64 from repository root with: `MSBuild.exe -property:TargetPlatformVersion=10.0.19041.0` * Installed CascadiaPackage_0.0.1.0_x64_Debug.msix and launched on 19042.867
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PlaySound functions were removed from OneCoreUAP_apiset.Lib in Windows 10 SDK 19041 because they did not actually belong there. Link to WinMM.Lib for PlaySoundW.
Validation Steps Performed
MSBuild.exe -property:TargetPlatformVersion=10.0.19041.0