Simplify HasCorrectTimeout #4042
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
reviewed
Nov 12, 2024
Youssef1313
reviewed
Nov 12, 2024
| /// <summary> | ||
| /// Gets a value indicating whether the instance has the correct test timeout signature. | ||
| /// </summary> | ||
| internal bool HasCorrectTimeout { get; private set; } |
There was a problem hiding this comment.
My personal preference here is to keep the constructors as they were before and switch this to:
Suggested change
| internal bool HasCorrectTimeout { get; private set; } | |
| internal bool HasCorrectTimeout => Timeout > 0; |
Youssef1313
reviewed
Nov 12, 2024
Comment on lines
-255
to
-265
| public void HasCorrectTimeoutShouldReturnFalseForMethodsWithInvalidTimeoutAttribute() | ||
| { | ||
| MethodInfo methodInfo = typeof(DummyTestClass).GetMethod("PublicMethodWithInvalidTimeout"); | ||
| Verify(!methodInfo.HasCorrectTimeout()); | ||
| } | ||
|
|
||
| public void HasCorrectTimeoutShouldReturnTrueForMethodsWithTimeoutAttribute() | ||
| { | ||
| MethodInfo methodInfo = typeof(DummyTestClass).GetMethod("PublicMethodWithTimeout"); | ||
| Verify(methodInfo.HasCorrectTimeout()); | ||
| } |
There was a problem hiding this comment.
These tests should probably be replaced by:
public void HasCorrectTimeoutShouldReturnFalseForMethodsWithInvalidTimeoutAttribute()
{
var timeoutAttribute = new TimeoutAttribute(-11);
Verify(!timeoutAttribute.HasCorrectTimeout);
}
public void HasCorrectTimeoutShouldReturnTrueForMethodsWithTimeoutAttribute()
{
var timeoutAttribute = new TimeoutAttribute(11);
Verify(timeoutAttribute.HasCorrectTimeout);
}Also, now PublicMethodWithInvalidTimeout and PublicMethodWithTimeout are unused I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was never called with a null value. so move it to a calculated property on the attribute