EuroSAT Subclass with Longitude-Based Splits

[burakekim]

SpatialSplitEuroSAT subclass overriding the default splits of EuroSAT.

Splits 60/20/20 by longitude.

Kudos to @calebrob6 for creating the spatial splits.

[adamjstewart]

We haven't really thought about the best way to handle multiple split definitions for a single dataset. Do we want to create a new class, or just a new parameter in the original class?

[burakekim]

We haven't really thought about the best way to handle multiple split definitions for a single dataset. Do we want to create a new class, or just a new parameter in the original class?

No preference. Adding a new parameter to the original class might keep things simpler and cut down on extra code though

[burakekim]

On a side note, it might make sense to give the users heads up that they need to manually set the stage in setup method

dataset = SpatialSplitEuroSAT(root=data_root, split="test", transforms=test_transforms_gpu)
dataloader = SpatialSplitEuroSATDataModule(root=data_root, batch_size=1)

# Setup the datasets for the 'test' stage
dataloader.setup(stage="test")

[adamjstewart]

On a side note, it might make sense to give the users heads up that they need to manually set the stage in setup method

That's something that can be documented in Lightning. I don't actually expect users to use the data module without a Trainer, which handles all of this for you.

[adamjstewart]

Also needs tests. Should be as simple as adding one more class name here, one config file similar to here, and one new line here.

[burakekim]

Also needs tests. Should be as simple as adding one more class name here, one config file similar to here, and one new line here.

Thanks for pointing out these! Done. Hope it is good now

[adamjstewart]

Also needs documentation: https://github.com/microsoft/torchgeo/blob/v0.5.2/docs/api/datasets.rst#L218

[adamjstewart]

Add to torchgeo.datamodules.__init__.py to solve the readthedocs error.

[adamjstewart]

Optional: we could put Spatial before 100 in the code and docs since users aren't really giong to use 100, it's only for demos. But it's prob fine to merge as is.

[burakekim]

Optional: we could put Spatial before 100 in the code and docs since users aren't really giong to use 100, it's only for demos. But it's prob fine to merge as is.

No preference: So I can do that!

[adamjstewart]

Let's do it then.

[burakekim]

Done!