Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use platform-independent path in getGitStatus #27

Closed
wants to merge 1 commit into from
Closed

Use platform-independent path in getGitStatus #27

wants to merge 1 commit into from

Conversation

Truffula
Copy link

Fixes #26.

@Truffula
Copy link
Author

Truffula commented Aug 7, 2023

@RyanCavanaugh are you able to review this?

@mark-dr
Copy link
Contributor

mark-dr commented Oct 16, 2023

FWIW I proposed the same fix in #23.

@erictheswift
Copy link

@RyanCavanaugh are you able to review this?

path.join() works much better on macOS as well as replacing \\ with path.sep will

@jakebailey
Copy link
Member

I merged #23, but thanks for sending this too.

@jakebailey jakebailey closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git check fails on MacOS
4 participants
@Truffula @mark-dr @erictheswift @jakebailey