Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark discriminator properties consistently as requiered #4663

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

AlitzelMendez
Copy link
Contributor

No description provided.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 10, 2024

All changed packages have been documented.

  • @typespec/openapi3
Show changes

@typespec/openapi3 - fix ✏️

Discriminator properties are marked as required regardless if they are in TypeSpec to match OpenAPI3 spec.

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@AlitzelMendez AlitzelMendez marked this pull request as ready for review October 10, 2024 22:39
@AlitzelMendez AlitzelMendez added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit de763ce Oct 14, 2024
22 checks passed
@AlitzelMendez AlitzelMendez deleted the fix-discriminator-should-be-requiered branch October 14, 2024 21:34
swatkatz pushed a commit to swatkatz/typespec that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OpenAPI - Discriminator properties are not consistently marked as required
3 participants