Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Code from TypeSpec in VSCode #5312

Merged
merged 87 commits into from
Jan 14, 2025
Merged

Conversation

chunyu3
Copy link
Contributor

@chunyu3 chunyu3 commented Dec 10, 2024

Fix #5025
Fix #5463

Integrate Code Generation in VSCode extension

@chunyu3 chunyu3 marked this pull request as draft December 10, 2024 01:48
@microsoft-github-policy-service microsoft-github-policy-service bot added the ide Issues for VS, VSCode, Monaco, etc. label Dec 10, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 10, 2024

All changed packages have been documented.

  • @typespec/internal-build-utils
  • typespec-vscode
Show changes

typespec-vscode - feature ✏️

integrate client SDK generation

@typespec/internal-build-utils - fix ✏️

resolve the program crash when there is no package name in package.json

@chunyu3 chunyu3 requested a review from witemple-msft as a code owner January 9, 2025 16:00
@microsoft microsoft deleted a comment from azure-sdk Jan 13, 2025
@chunyu3
Copy link
Contributor Author

chunyu3 commented Jan 13, 2025

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 13, 2025

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs 🛝 VSCode Extension

allenjzhang
allenjzhang previously approved these changes Jan 14, 2025
Copy link
Member

@allenjzhang allenjzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a future enhancement, if main.tsp is not found, should prompt them for an entry point tsp file. main.tsp does NOT need there.

@allenjzhang allenjzhang dismissed stale reviews from timotheeguerin and themself January 14, 2025 18:39

Tim OOF. Concern has been address.

Copy link
Member

@allenjzhang allenjzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a future enhancement, if main.tsp is not found, should prompt them for an entry point tsp file. main.tsp does NOT need there.

@allenjzhang
Copy link
Member

@chunyu3, @RodgeFu, I still see there are a few things should be cleaned up as you should purely rely on the TypeSpec config and build capabilities.

Since this PR has been out long and isolated to VSCode packages, I will merge it for release. Let's make quick follow up on optmization asap. Thanks

@allenjzhang allenjzhang added this pull request to the merge queue Jan 14, 2025
Merged via the queue into microsoft:main with commit 98f7cd5 Jan 14, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ide Issues for VS, VSCode, Monaco, etc.
Projects
None yet
7 participants