[core] Fix enum-driven visibility consistency issues when projections are used #5525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getLifecycleVisibilityEnum
to honor projections whenprogram
is aProjectedProgram
.Projector
to projectEnumValue
values only, so that they remain consistent with projectedEnum
andEnumMember
references. If the projection of the underlyingEnumMember
does not result in anotherEnumMember
(i.e. it projects to some other type, which I think should be rare, but possible according to the type system), the projector gives up and returns the original enum member.A more complex solution would try to project all values, but this could damage the scalar hierarchy and there is an open issue to consider removing projections in favor of mutators in the future.
Closes #5450
Closes #5461