[benchmark] Fix build failure under QNX

[jimwang118]

Fixes #35510

Use C++ casts.

• Changes comply with the maintainer guide
• SHA512s are updated for each updated download
• The "supports" clause reflects platforms that may be fixed by this new version
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

x86-windows
x64-windows

[BillyONeal]

I think this needs to be submitted upstream, and I would like to see confirmation from @Arech that it actually fixes something because the problem will not repro on anything we currently have the capacity to test.

[Arech]

Well, with the exception of adding -Werror=old-style-cast it's the same patch, that I have suggested, so it should work...
But I'll test it tomorrow anyway and will get back to you with the results. It's 23:35 here, good night everyone...

[jimwang118]

Track the upstream issue 1707.

[Arech]

I can confirm that the PR indeed compiles and works on QNX as expected

In the manifest:

"default-registry": {
  "kind": "git",
  "repository": "https://github.com/jimwang118/vcpkg",
  "reference": "fixbenchmark",
  "baseline": "0d6278ea26eecd1ebd3cbb2d183d3eb0cee6cf5c"
},

benchmarks$ . $QNXSDP/qnx710/qnxsdp-env.sh
...
benchmarks$ rm -rf ./build_qnx; cmake -B ./build_qnx -G Ninja -DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=aarch64-qnx.cmake -DCMAKE_BUILD_TYPE=Release && cmake --build ./build_qnx -j 8
...
-- Running vcpkg install
warning: Embedding `vcpkg-configuration` in a manifest file is an EXPERIMENTAL feature.
Fetching registry information from https://github.com/jimwang118/vcpkg (fixbenchmark)...
...
The following packages will be built:
    benchmark:[email protected]#1 -- ...
...
Installing 85/165 benchmark:[email protected]#1...
Building benchmark:[email protected]#1...
-- [OVERLAY] Loading triplet configuration from: .../arm64-qnx.cmake
...
-- Applying patch fix_qnx.patch
...
-- Configuring arm64-qnx
-- Building arm64-qnx-dbg
-- Building arm64-qnx-rel
...

I run the binary on a device with QNX and it worked as expected.

[jimwang118]

The upstream fix PR 1739 has been merged.