Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using new VS Code WorkspaceEditMetadata API for Rename #4990

Closed
Colengms opened this issue Feb 20, 2020 · 1 comment
Closed

Switch to using new VS Code WorkspaceEditMetadata API for Rename #4990

Colengms opened this issue Feb 20, 2020 · 1 comment
Assignees
@Colengms
Labels
Feature: Rename fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone
0.28.0

Comments

@Colengms
Copy link
Contributor

VS Code has added a new API for previewing refactor operations. microsoft/vscode#77728

Creating this issue to track switching to using it instead of our own Rename UI.
@Colengms Colengms self-assigned this Feb 20, 2020
@Colengms Colengms added this to the On Deck milestone Feb 20, 2020
@bobbrow bobbrow modified the milestones: On Deck, Post-v1 Feb 20, 2020
@sean-mcmanus sean-mcmanus modified the milestones: Post-v1, 1.0 Feb 27, 2020
@Colengms Colengms mentioned this issue Mar 19, 2020
Merged
@Colengms Colengms added the fixed Check the Milestone for the release in which the fix is or will be available. label Apr 1, 2020
@elahehrashedi
Copy link
Contributor

This issue is fixed in 0.28.0.
0.28.0 release: https://github.com/microsoft/vscode-cpptools/releases/tag/0.28.0

@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Colengms Colengms

Labels
Feature: Rename fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Milestone
0.28.0
Development

No branches or pull requests
4 participants
@bobbrow @elahehrashedi @sean-mcmanus @Colengms