Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rename UI in favor of new WorkspaceEdit Preview API #5133

Merged
merged 19 commits into from
Apr 1, 2020

Conversation

Colengms
Copy link
Contributor

@Colengms Colengms commented Mar 16, 2020

Removes code for Rename UI. #4990
Switches to using WorkspaceEdit Preview API for rename confirmations.

image

Note that there does not appear to be a way for us to control the sort order of groups (when viewing by group). VS Code appears to intentionally put our group containing confirmed references last.

Note that the icons for reference type are displayed only on groups, when viewing by group.

Also addresses #4131 , as updating to the new VS Code API's require switching to vscode-test.

@sean-mcmanus sean-mcmanus added this to the 1.0 milestone Mar 17, 2020
@sean-mcmanus
Copy link
Contributor

Can we get VS Code to add some sort order so we can force the Confirmed Reference type to come first? Otherwise, that seems like a major UI regression, since the confirmed references are the most important ones and could otherwise be scrolled off the screen.

@Colengms
Copy link
Contributor Author

Colengms commented Apr 1, 2020

Can we get VS Code to add some sort order so we can force the Confirmed Reference type to come first? Otherwise, that seems like a major UI regression, since the confirmed references are the most important ones and could otherwise be scrolled off the screen.

They appear to be intentionally putting confirmed groups last, so it may be by-design. Perhaps the most important ones are the ones that need attention (unconfirmed), so perhaps this is better? Since this is a shipped feature, perhaps open an issue in their repo?

@sean-mcmanus
Copy link
Contributor

Can we get VS Code to add some sort order so we can force the Confirmed Reference type to come first? Otherwise, that seems like a major UI regression, since the confirmed references are the most important ones and could otherwise be scrolled off the screen.

They appear to be intentionally putting confirmed groups last, so it may be by-design. Perhaps the most important ones are the ones that need attention (unconfirmed), so perhaps this is better? Since this is a shipped feature, perhaps open an issue in their repo?

I filed issue microsoft/vscode#94210

Extension/package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

@Colengms Colengms merged commit 289562e into master Apr 1, 2020
@Colengms Colengms deleted the coleng/use_rename_preview_api branch April 1, 2020 23:26
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants