-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Rename UI in favor of new WorkspaceEdit Preview API #5133
Conversation
…into coleng/use_rename_preview_api
…into coleng/use_rename_preview_api
Can we get VS Code to add some sort order so we can force the Confirmed Reference type to come first? Otherwise, that seems like a major UI regression, since the confirmed references are the most important ones and could otherwise be scrolled off the screen. |
They appear to be intentionally putting confirmed groups last, so it may be by-design. Perhaps the most important ones are the ones that need attention (unconfirmed), so perhaps this is better? Since this is a shipped feature, perhaps open an issue in their repo? |
…into coleng/use_rename_preview_api
…crosoft/vscode-cpptools into coleng/use_rename_preview_api
I filed issue microsoft/vscode#94210 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...
Removes code for Rename UI. #4990
Switches to using WorkspaceEdit Preview API for rename confirmations.
Note that there does not appear to be a way for us to control the sort order of groups (when viewing by group). VS Code appears to intentionally put our group containing confirmed references last.
Note that the icons for reference type are displayed only on groups, when viewing by group.
Also addresses #4131 , as updating to the new VS Code API's require switching to
vscode-test
.