Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clean user agent string instead of appVersion when userAgentData is unavailable. #200

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Use clean user agent string instead of appVersion when userAgentData is unavailable. #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/browser/telemetryReporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ function getBrowserRelease(navigator: Navigator): string {
const browser = navigator.userAgentData.brands[navigator.userAgentData.brands.length - 1];
return `${navigator.userAgentData.platform} - ${browser?.brand} v${browser?.version}}`;
} else {
return navigator.appVersion;
// clean the user agent using the logic from here:
// https://github.com/microsoft/vscode/blob/main/src/vs/workbench/services/telemetry/browser/workbenchCommonProperties.ts#L14C1-L21C2
return navigator.userAgent.replace(/(\d+\.\d+)(\.\d+)+/g, "$1");
}
}

Expand Down
Loading