Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

go.mod - syntax highlighting for comments has some quirks #2423

Closed
brainsnail opened this issue Apr 6, 2019 · 3 comments
Closed

go.mod - syntax highlighting for comments has some quirks #2423

brainsnail opened this issue Apr 6, 2019 · 3 comments
Labels
go-modules Related to Go modules help wanted

Comments

@brainsnail
Copy link
Contributor

There are a few scenarios where the comment highlighting doesn't work as expected without a space preceding the comment pattern -// :

Doesn't recognize the comment

  • After the go keyword and version
  • After the module keyword and module

image

Recognizes the comment string, but breaks subsequent highlighting

  • After the replace keyword before a paren

image

Originally posted by @brainsnail in #2410 (comment)
@ramya-rao-a ramya-rao-a added bug go-modules Related to Go modules help wanted labels Apr 6, 2019
@ramya-rao-a
Copy link
Contributor

cc @calebdoxsey

calebdoxsey added a commit to calebdoxsey/vscode-go that referenced this issue Apr 7, 2019
@calebdoxsey
fixes microsoft#2423, allow no space before comment, do not allow dou…
a41fc14 
…ble slash in unqouted string
@calebdoxsey calebdoxsey mentioned this issue Apr 7, 2019
Merged
@calebdoxsey
Copy link
Contributor

@ramya-rao-a @brainsnail I think #2424 should fix these issues.

@ramya-rao-a
Copy link
Contributor

This bug fix is now available in the latest update (0.11.0) to the Go extension. Thanks @calebdoxsey and @brainsnail!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
go-modules Related to Go modules help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@calebdoxsey @brainsnail @ramya-rao-a