Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isort.check setting #125

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Add isort.check setting #125

merged 3 commits into from
Oct 19, 2022

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Oct 18, 2022 •
edited
Loading

@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Oct 18, 2022
@karthiknadig karthiknadig self-assigned this Oct 18, 2022
luabud
luabud reviewed Oct 18, 2022
View reviewed changes
package.nls.json Outdated
@@ -8,6 +8,7 @@
"settings.logLevel.off.description": "Most logging is turned off, any information that is always logged might still be shown.",
"settings.logLevel.warn.description": "Includes all messages in the error category and any additional warnings.",
"settings.args.description": "Arguments passed in. Each argument is a separate string in the array.",
"settings.check.description": "Runs `isort` in check mode, and reports import sort issues.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to make sure I understand it correctly: check will control whether the "imports are not correctly sorted" warning, is that correct?
Maybe something like "Controls whether to run isort and report import sort issues"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct, this is for showing the error/warning that imports are not sorted. I will update the text.

karthiknadig
karthiknadig commented Oct 19, 2022
View reviewed changes
package.nls.json Outdated Show resolved Hide resolved
@karthiknadig karthiknadig mentioned this pull request Oct 19, 2022
Closed
@karthiknadig karthiknadig requested a review from karrtikr October 19, 2022 20:02
@karrtikr karrtikr changed the title Add 'check' setting. Add 'check' setting Oct 19, 2022
karrtikr
karrtikr approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Removed periods from PR title as it appears weirdly in changelogs.

image

@karrtikr karrtikr changed the title Add 'check' setting Add isort.check setting Oct 19, 2022
@karthiknadig karthiknadig merged commit 035c147 into microsoft:main Oct 19, 2022
@karthiknadig karthiknadig deleted the add-check-setting branch October 19, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luabud luabud luabud left review comments

@karrtikr karrtikr karrtikr approved these changes

@eleanorjboyd eleanorjboyd Awaiting requested review from eleanorjboyd

Assignees

@karthiknadig karthiknadig

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Imports are incorrectly sorted and/or formatted.
3 participants
@karthiknadig @karrtikr @luabud