Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default for isort.check to false #126

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Set default for isort.check to false #126

merged 1 commit into from
Oct 19, 2022

Conversation

karthiknadig
Copy link
Member

No description provided.

@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Oct 19, 2022
@karthiknadig karthiknadig requested a review from karrtikr October 19, 2022 21:23
@karthiknadig karthiknadig self-assigned this Oct 19, 2022
@karthiknadig karthiknadig marked this pull request as ready for review October 19, 2022 21:26
@karthiknadig karthiknadig requested a review from luabud October 19, 2022 22:27
karrtikr
karrtikr reviewed Oct 19, 2022
View reviewed changes
Copy link
Contributor

@karrtikr karrtikr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we seen enough reports that warrant this change? I personally like it 😄

@karthiknadig karthiknadig merged commit 67a9dc0 into microsoft:main Oct 19, 2022
@karthiknadig karthiknadig deleted the default-check-false branch October 19, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrtikr karrtikr karrtikr approved these changes

@luabud luabud Awaiting requested review from luabud

Assignees

@karthiknadig karthiknadig

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karthiknadig @karrtikr