Support for isort in server less mode
#207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleanorjboyd
approved these changes
Jan 22, 2023
| @@ -104,14 +106,20 @@ export async function getWorkspaceSettings( | |||
| export function checkIfConfigurationChanged(e: ConfigurationChangeEvent, namespace: string): boolean { | |||
| const settings = [ | |||
| `${namespace}.check`, | |||
| `${namespace}.trace`, | |||
There was a problem hiding this comment.
Is this a permanent change? Just curious about why the switch away from their set log level.
There was a problem hiding this comment.
this was a missed change when we switched to logLevel setting. We moved from trace to logLevel because language server itself internally uses trace setting. Our setting was overriding that. We are eventually going to get rid of all logging, and replace it with VS Codes own logging.
There was a problem hiding this comment.
thank you for the explanation sounds good!
This was referenced Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.