Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link to Microsoft OpenJDK #631

Merged
merged 2 commits into from
May 21, 2021
Merged

add link to Microsoft OpenJDK #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ca0467
add link to Microsoft OpenJDK
Eskibear May 20, 2021
303e6ac
update color
Eskibear May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/java-runtime/assets/jdk.installation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export class JdkInstallationPanel extends React.Component<JdkInstallationPanelPr
<a className="nav-link active" id="adoptOpenJdkTab" data-toggle="tab" href="#adoptOpenJdkPanel" role="tab" aria-controls="adoptOpenJdkPanel" aria-selected="true" title="Reliable source of OpenJDK binaries for all platforms">AdoptOpenJDK</a>
</li>
<li className="nav-item">
<a className="nav-link" id="otherJdkTab" data-toggle="tab" href="#otherJdkPanel" role="tab" aria-controls="otherJdkPanel" aria-selected="false" title="Other choices">Others</a>
<a className="nav-link" id="otherJdkTab" data-toggle="tab" href="#otherJdkPanel" role="tab" aria-controls="otherJdkPanel" aria-selected="false" title="Other choices">Others<span className="red-dot"></span></a>
</li>
</ul>
<div className="tab-content" id="jdkTabContent">
Expand Down Expand Up @@ -148,6 +148,7 @@ export class JdkInstallationPanel extends React.Component<JdkInstallationPanelPr
</div>
<div className="tab-pane fade" id="otherJdkPanel" role="tabpanel" aria-labelledby="otherJdkTab">
<ul id="jdkProviderList" className="list-unstyled">
<li><a href="command:java.helper.openUrl?%22https%3A%2F%2Fwww.microsoft.com%2Fopenjdk%22" title="Microsoft Build of OpenJDK">Microsoft Build of OpenJDK</a><sup className="newtag">NEW</sup></li>
Copy link
Member

@jdneo jdneo May 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directly use Badge from bootstrap? https://getbootstrap.com/docs/4.6/components/badge/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Currently it's exactly what I want.

<li><a href="command:java.helper.openUrl?%22https%3A%2F%2Fwww.azul.com%2Fdownloads%2Fazure-only%2Fzulu%2F%22" title="Recommended for Microsoft Azure Cloud and Azure Stack applications">Azul Zulu Enterprise build of OpenJDK for Azure</a></li>
<li><a href="command:java.helper.openUrl?%22https%3A%2F%2Fdevelopers.redhat.com%2Fproducts%2Fopenjdk%2Fdownload%22" title="Red Hat build of OpenJDK">Red Hat build of OpenJDK</a></li>
<li><a href="command:java.helper.openUrl?%22https%3A%2F%2Fsapmachine.io%2F%22" title="SapMachine - An OpenJDK release maintained and supported by SAP">SapMachine - An OpenJDK release maintained and supported by SAP</a></li>
Expand Down
16 changes: 16 additions & 0 deletions src/java-runtime/assets/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
div.container {
min-width: 550px;
}

sup.newtag {
color: var(--vscode-terminal-ansiRed);
font-weight: bold;
margin-left: 0.2rem;
}

span.red-dot {
height: 0.5rem;
width: 0.5rem;
background-color: var(--vscode-terminal-ansiRed);
border-radius: 50%;
display: inline-block;
margin-left: 0.2rem;
margin-bottom: 0.2rem;
}