Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open help center to side on walkthrough #723

Merged
merged 2 commits into from
Aug 11, 2021
Merged

open help center to side on walkthrough #723

merged 2 commits into from
Aug 11, 2021

Conversation

Eskibear
Copy link
Member

Signed-off-by: Yan Zhang [email protected]

@Eskibear Eskibear requested review from jdneo and nickzhums August 10, 2021 08:55
@Eskibear
Copy link
Member Author

For "Java Help Center":

  • if triggered from command palette, it always opens to right (beside).
  • if triggered from walkthrough, it opens to left side (viacommand:toSide:), same as other pages.

@Eskibear
Copy link
Member Author

Treatment Group:

treatment.mp4

Control Group:

control.mp4

jdneo
jdneo reviewed Aug 11, 2021
View reviewed changes
src/welcome/index.ts Show resolved Hide resolved
src/welcome/index.ts Outdated Show resolved Hide resolved
@Eskibear
remove comments
46210b7 
Signed-off-by: Yan Zhang <[email protected]>
@Eskibear Eskibear merged commit 1e5e1da into main Aug 11, 2021
@Eskibear Eskibear deleted the wt branch August 11, 2021 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo approved these changes

@nickzhums nickzhums Awaiting requested review from nickzhums

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eskibear @jdneo