Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Interactive Window tests failing #11322

Closed
roblourens opened this issue Sep 7, 2022 · 8 comments
Closed

All Interactive Window tests failing #11322

roblourens opened this issue Sep 7, 2022 · 8 comments
Assignees
Labels
debt Code quality issues flaky test Test that is intermittently failing triage-needed Issue needs to be triaged
Milestone

Comments

@roblourens
Copy link
Member

Something must have gone wrong in setup because it seems that every IW test failed. I saw the same thing in another run from yesterday

https://github.com/microsoft/vscode-jupyter/runs/8232442931?check_suite_focus=true

@roblourens roblourens added the flaky test Test that is intermittently failing label Sep 7, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Sep 7, 2022
@rebornix rebornix added this to the September 2022 milestone Sep 7, 2022
@rebornix
Copy link
Member

@DonJayamanne
Copy link
Contributor

Looks like some issues in Core, something could not be loaded, I've seen this in the past as well, and only manaaged to get things working after re-installing VS Code.
I.e. when ever i see Could not register service workers: TypeError: Failed to register a ServiceWorker I know its a bug in VS Code core.

2022-09-13T16:59:20.8487109Z A bad HTTP response code (504) was received when fetching the script.
2022-09-13T16:59:20.8521684Z Webview fatal error: Error: Could not register service workers: TypeError: Failed to register a ServiceWorker for scope ('https://14ml6ta8ob5jtoorsm0fmomggogpr45tanlf3u6jkl91p3ra1h7t.vscode-cdn.net/insider/1a55beb2aaee64eb8d0cbe5b61b10088bbc6c895/out/vs/workbench/contrib/webview/browser/pre/') with script ('https://14ml6ta8ob5jtoorsm0fmomggogpr45tanlf3u6jkl91p3ra1h7t.vscode-cdn.net/insider/1a55beb2aaee64eb8d0cbe5b61b10088bbc6c895/out/vs/workbench/contrib/webview/browser/pre/service-worker.js?v=4&vscode-resource-base-authority=vscode-resource.vscode-cdn.net&remoteAuthority='): A bad HTTP response code (504) was received when fetching the script..
2022-09-13T16:59:20.8833668Z Error loading webview: Error: Could not register service workers: TypeError: Failed to register a ServiceWorker for scope ('https://14ml6ta8ob5jtoorsm0fmomggogpr45tanlf3u6jkl91p3ra1h7t.vscode-cdn.net/insider/1a55beb2aaee64eb8d0cbe5b61b10088bbc6c895/out/vs/workbench/contrib/webview/browser/pre/') with script ('https://14ml6ta8ob5jtoorsm0fmomggogpr45tanlf3u6jkl91p3ra1h7t.vscode-cdn.net/insider/1a55beb2aaee64eb8d0cbe5b61b10088bbc6c895/out/vs/workbench/contrib/webview/browser/pre/service-worker.js?v=4&vscode-resource-base-authority=vscode-resource.vscode-cdn.net&remoteAuthority='): A bad HTTP response code (504) was received when fetching the script..

@roblourens
Copy link
Member Author

These have both been in web. This is the same sort of webview error that we have seen in vscode integration tests, microsoft/vscode#126371 (comment)

cc @mjbvz, is there anything we can do here?

If this is behind lots of flakiness in vscode-jupyter web tests I suggest we make all web tests optional or add a retry, but we clearly need to test web

@mjbvz
Copy link
Contributor

mjbvz commented Sep 19, 2022

@roblourens This appears to be an electron bug microsoft/vscode#125993

Unfortunately I don't know how to resolve it or work around it

@roblourens
Copy link
Member Author

That issue sounds like it's specifically talking about an error like The document is in an invalid state, this is a different message, or is that issue about all "Could not register service worker" issues?

@amunger amunger modified the milestones: September 2022, October 2022 Sep 26, 2022
@rebornix
Copy link
Member

image

Some of the interactive window execution tests are flaky in the last week.

@amunger
Copy link
Contributor

amunger commented Sep 30, 2022

The vast majority of the failures are happening in web.
The failures aren't all due to that 504 error. The one that I'm currently looking into never starts the kernel for the set of tests that fail:

Get default Remote Controller, Class name = ControllerDefaultService, completed in 0ms, has a truthy return value, Arg 1: "interactive", Arg 2: undefined, Return Value: <Return value cannot be serialized for logging>
CreateDefaultRemoteController
Intiailize notebook communications for editor Interactive-1.interactive
Test Remote Jupyter Server Output: [I 16:18:07.094 NotebookApp] Starting buffering for

[MISSING from failure case]
Test Remote Jupyter Server Output: [I 21:58:03.908 NotebookApp] Creating new notebook in 
info 21:58:03.885:  InteractiveWindow.ts.createExecutionPromise.start
verbose 21:58:03.885:  start the kernel, options.disableUI=false
Starting Jupyter Session startUsingRemoteKernelSpec

getRemoteUri: http://localhost:
list kernel specs

It's hard to see what leads to triggering the kernel to start from the logs in a successful test run though, most of the previous logs are about disposing objects from previous tests. Need to try and dig through the code to see if I can find why kernels would just stop trying to initialize for an entire suite.

@amunger amunger modified the milestones: October 2022, November 2022 Oct 24, 2022
@rebornix rebornix removed their assignment Nov 23, 2022
@amunger amunger modified the milestones: November 2022, December 2022 Nov 28, 2022
@amunger amunger added the debt Code quality issues label Dec 1, 2022
@amunger
Copy link
Contributor

amunger commented Dec 6, 2022

haven't seen this for a while

@amunger amunger closed this as completed Dec 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues flaky test Test that is intermittently failing triage-needed Issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

5 participants