-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deal with Notebook smoke/web tests #126371
Comments
I'll recommend us removing them. |
Related, they are entirely disabled for web in integration tests: #126384 |
Current status: I'd like to delete the ones that have just always been flaky but leave at least a couple so we open a notebook during smoketesting. But opening a notebook fails in the web smoketests due to something with the webview. |
@mjbvz can you look at this? I also can't do a web integration test for (I think) the same reason.
Works like in yarn web though, I don't know what the difference is |
I would like to enrich our hot-exit smoke tests to also open a notebook, make it dirty and verify the contents are there after restart. But given the notebook tests are disabled, it looks I am blocked on this? What is the status? |
@mjbvz would you have time to look at this in December/Jan? |
Yes I think that's ok in this case. We cancel resource loads when the webview is closed which is likely why you see this error printed |
For microsoft#126371 This single test passes for me. Will look at re-enabling individual tests next
For microsoft#126371 These pass for me locally
For microsoft#126371 Co-authored-by: Matt Bierner <[email protected]>
The entire Notebook smoke test suite is currently entirely skipped. We should address this by either fixing the tests or removing them altogether.
cc @jrieken @roblourens
The text was updated successfully, but these errors were encountered: