Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'data' to the list of item defaults for completion items. #1237

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

dbaeumer
Copy link
Member

No description provided.

@dbaeumer dbaeumer enabled auto-merge (squash) April 21, 2023 07:10
@dbaeumer dbaeumer requested a review from aeschli April 21, 2023 07:11
@dbaeumer dbaeumer merged commit 0b7acc1 into main Apr 21, 2023
@dbaeumer dbaeumer deleted the dbaeumer/vocational-amphibian-sapphire branch April 21, 2023 07:20
@DanTup
Copy link
Contributor

DanTup commented Aug 21, 2023

@dbaeumer is the intention here that data on a completion item completely replaces itemDefaults.data, or will the objects be merged?

If the entire object is replaced (which I suspect is the case), would you consider support for a way to merge it? In our data, we currently have some fields that are the same for a large number of completions and I'm looking at reducing payload sizes again because when running in the browser it can make large completion lists very slow (isIncomplete has some issues and VS Code doesn't support streaming results, so we tend to produce large lists because users want every symbol, imported or not).

@dbaeumer
Copy link
Member Author

The current strategy is that if a item has no data the one from the defaults is taken. There is currently no merge. If we want to provide merge then I would rather add another defaults field to make this very clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants