Add filter state management #18602
Open
Add filter state management #18602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cssuh
requested review from
kburtram,
aasimkhan30,
caohai,
laurennat,
lewis-sanchez and
Benjin
as code owners
PR Changes
|
Benjin
reviewed
Jan 28, 2025
Comment on lines
421
to
434
| this._queryResultWebviewPanelControllerMap | ||
| .get(uri) | ||
| .postNotification( | ||
| DefaultWebviewNotifications.updateStorage, | ||
| uri, | ||
| ); | ||
| } else { | ||
| try { | ||
| this._queryResultWebviewPanelControllerMap | ||
| .get(uri) | ||
| .postNotification( | ||
| DefaultWebviewNotifications.updateStorage, | ||
| uri, | ||
| ); |
There was a problem hiding this comment.
These are identical, right? So the only thing that differs based on usePanelController is whether to catch exceptions? What happens if usePanelController is true and it throws?
There was a problem hiding this comment.
Yeah so there are a few scenarios I'm trying to account for here (in the same order) -
- The user has the usePanelController setting checked and is applying filters to a grid in the "new tab" area
- The user doesn't have the usePanelController setting checked, but is still working in the panel area (they selected open in new tab, but don't have the setting updated to reflect this). In this case the panelControllerMap will exist in which case we want to send the notiification to the panelcontrollermap.
- The user is just working in the default area for the resultgrid, the bottom area where the vscode terminal also exists. We want to delete the filters for this grid area in this scenario.
| DefaultWebviewNotifications.updateStorage, | ||
| uri, | ||
| ); | ||
| } catch { |
There was a problem hiding this comment.
what does this throwing mean? Is it an error that needs logging/telemetry?
There was a problem hiding this comment.
hopefully the above comment explains this, maybe there's a better way to handle all these scenarios more gracefully.
src/reactviews/pages/QueryResult/table/plugins/headerFilter.plugin.ts
Outdated
Show resolved
Hide resolved
| const gridColumnMapArray = store.get( | ||
| this.queryResultState.state.uri!, | ||
| ) as GridColumnMap[]; | ||
| if (gridColumnMapArray) { |
There was a problem hiding this comment.
some comments in here would be nice; there's a lot of slicing and dicing of data with hardcoded indexes going on
src/reactviews/pages/QueryResult/table/plugins/headerFilter.plugin.ts
Outdated
Show resolved
Hide resolved
src/reactviews/pages/QueryResult/table/plugins/headerFilter.plugin.ts
Outdated
Show resolved
Hide resolved
Benjin
reviewed
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds filter state management
Before:
filters were only tracked on a column.id level, which led to issues like #18514.
After:
Filters are tracked at a (query editor) uri level, containing multiple sets of filters for each grid id and column id respectively.
I also added a singleton store, which allows us to store state outside of the react state (this is needed in cases where we don't want to trigger a re-render which happens every time the react state is updated). We don't need to re-render here because that is triggered and managed by the slickgrid library.
Fixes #18514