Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Stop debugging on program end #112

Merged
merged 2 commits into from
Jun 19, 2017
Merged

Stop debugging on program end #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f2d82a
Stop debugging on program end - Fix #11
rianadon Jun 19, 2017
09fa862
Do not run program end test on old Node.js versions
rianadon Jun 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/nodeDebugAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,16 @@ export class NodeDebugAdapter extends ChromeDebugAdapter {
super.commonArgs(args);
}

protected hookConnectionEvents(): void {
super.hookConnectionEvents();

this.chrome.Runtime.onExecutionContextDestroyed(params => {
if (params.executionContextId === 1) {
this.terminateSession('Program ended');
}
});
}

protected async doAttach(port: number, targetUrl?: string, address?: string, timeout?: number): Promise<any> {
await super.doAttach(port, targetUrl, address, timeout);
this.beginWaitingForDebuggerPaused();
Expand Down
8 changes: 6 additions & 2 deletions test/adapter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,12 @@ suite('Node Debug Adapter etc', () => {
});

suite('launch', () => {
// #11
test.skip('should run program to the end', () => {
test('should run program to the end', () => {
if (testSetup.compareSemver(process.version, 'v8.0.0') < 0) {
// Skip test if the node version doesn't emit the Runtime.executionContextDestroyed event
return Promise.resolve();
}

const PROGRAM = path.join(DATA_ROOT, 'program.js');

return Promise.all([
Expand Down