Unnecessary send text to terminal clutters shell history

[YulienPohl]

Type: Bug

Behaviour

Expected vs. Actual

When using PowerShell 7 with PSReadLine, every time the Python extension is started, the terminal message:
echo C:\Users\Yulie\AppData\Local\Microsoft\WindowsApps\Microsoft.PowerShell_8wekyb3d8bbwe\pwsh.exe
is sent that floods my shell history file.

The bug has occurred in version 2023.22.0 and 2023.22.1. The previous version 2023.20.0 is not affected.

Diagnostic data

• Python version (& distribution if applicable, e.g. Anaconda): 3.11.4
• Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Conda
• Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

2024-01-22 14:35:46.767 [info] Experiment 'pythonRecommendTensorboardExt' ist aktiv
2024-01-22 14:35:46.767 [info] Experiment 'pythonREPLSmartSend' ist aktiv
2024-01-22 14:35:46.767 [info] Experiment 'pythonSurveyNotification' ist aktiv
2024-01-22 14:35:46.767 [info] Experiment 'pythonTerminalEnvVarActivation' ist aktiv
2024-01-22 14:35:46.767 [info] Experiment 'pythonTestAdapter' ist aktiv
2024-01-22 14:35:46.984 [info] Default formatter is set to null for workspace
2024-01-22 14:35:47.018 [info] Test server listening.
2024-01-22 14:35:47.025 [info] Pfad zum Python-Interpreter: ~\.conda\envs\py311\python.exe
2024-01-22 14:35:47.033 [info] > conda info --json
2024-01-22 14:35:48.719 [info] > ~\.conda\Scripts\conda.exe info --json
2024-01-22 14:35:48.795 [info] > ~\.conda\envs\py311\Scripts\conda.exe info --json
2024-01-22 14:35:50.456 [info] > ~\.conda\envs\py311\condabin\conda.bat info --json
2024-01-22 14:35:51.940 [info] > ~\.conda\envs\py311\python.exe -I ~\.vscode\extensions\ms-python.python-2023.22.0\pythonFiles\get_output_via_markers.py ~\.vscode\extensions\ms-python.python-2023.22.0\pythonFiles\interpreterInfo.py
2024-01-22 14:35:52.043 [info] Send text to terminal: echo C:\Users\Yulie\AppData\Local\Microsoft\WindowsApps\Microsoft.PowerShell_8wekyb3d8bbwe\pwsh.exe
2024-01-22 14:35:55.044 [info] Shell integration is not working for powershellCore
2024-01-22 14:35:55.045 [warning] Shell integration is not active, environment activated maybe overriden by the shell.

User Settings

languageServer: "Jedi"

testing
• pytestEnabled: true

terminal
• activateEnvironment: false

Extension version: 2023.22.0
VS Code version: Code 1.85.1 (0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2, 2023-12-13T09:49:37.021Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item	Value
CPUs	AMD Ryzen 5 1600 Six-Core Processor (12 x 3200)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)	undefined
Memory (System)	15.95GB (10.90GB free)
Process Argv	--crash-reporter-id 31a76425-10b2-4370-8107-7c2aeccb8a81
Screen Reader	no
VM	0%

A/B Experiments

vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:30899288
vscaat:30438848
vsclangdc:30486549
c4g48928:30535728
azure-dev_surveyone:30548225
a9j8j154:30646983
962ge761:30933248
pythongtdpath:30769146
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
dsvsc019acf:30933242

[karrtikr]

Thanks for the bug report! We just wanted to quickly acknowledge we received it and can confirm the issue. I'll leave the issue open to investigate what we can do about it.

[NodeJSmith]

Just want to add my two cents, I found this issue while trying to figure out why I was seeing echo /usr/bin/zsh in my command history (zsh, WSL2). While searching for the cause I found that my vscode python logs have a bunch of these lines:

/home/jessica/.vscode-server/data/logs/20240122T043331/exthost11/ms-python.python/Python.log
10:2024-01-23 15:36:44.330 [info] Send text to terminal: echo /usr/bin/zsh

/home/jessica/.vscode-server/data/logs/20240122T043331/exthost4/ms-python.python/Python.log
8:2024-01-23 11:32:04.950 [info] Send text to terminal: echo /usr/bin/zsh

I see the logs in my vscode log files going back to early January but I only see history in my .zsh_history starting around the 14th of January, so I'm not sure what changed. Happy to provide additional info it will help.

[karrtikr]

We can confirm the issue, thanks.

[araovo]

Setting integrated.shellIntegration.enable to false could prevent this from happening

[karrtikr]

Investigation results:

We were sending dummy commands to terminal to check whether shell integration is working. But it seems to have a couple of issues:

• Ends up cluterring terminal history
• Does not work for hidden terminals: onDidExecuteTerminalCommand does not fire events for hidden terminal vscode#199611

I've created #22850 which solves this for now. But this means that we need a better way to check whether shell integration is working.

[karrtikr]

Fix should be out in the pre-release version of the extension, use the following to try it out: