Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted Types compatibility: use DOM API for creating HTML elements instead of string concatenation in welcomeOverlay.ts #105505

Closed
annkamsk opened this issue Aug 27, 2020 · 0 comments · Fixed by #105506
Assignees
Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders workbench-welcome Welcome page issues
Milestone

Comments

@annkamsk
Copy link
Contributor

The next step in resolving #103699. The Trusted Types violation here is setting an HTMLElement’s text content by assigning it to .innerHTML. Because in all of the cases the HTMLElement is already created with dom.ts#$ function, the idea is to pass the text as its children argument.
That is to replace: dom.append(parent, $(‘span’)).innerHTML = text with dom.append(parent, $(‘span’, {}, text)).

@chrmarti chrmarti added engineering VS Code - Build / issue tracking / etc. workbench-welcome Welcome page issues labels Aug 28, 2020
@chrmarti chrmarti added this to the August 2020 milestone Aug 28, 2020
chrmarti added a commit that referenced this issue Aug 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders workbench-welcome Welcome page issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@chrmarti @annkamsk and others