Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet doesn't add the class with tag A in jsx and html files. #123399

Closed
iamrealmarsel opened this issue May 9, 2021 · 0 comments
Closed

Emmet doesn't add the class with tag A in jsx and html files. #123399

iamrealmarsel opened this issue May 9, 2021 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues insiders-released Patch has been released in VS Code Insiders upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone

Comments

@iamrealmarsel
Copy link

Issue Type: Bug

JSX file.

Initially:

function MainLayout({ children }) {
  return (
    <div>
      <Header />
      {children}
      <span>I want to be wrapped by the tag A with some className</span>
      <Footer />
    </div>
  );
}

Wrap the span tag by a tag with className link using the command editor.emmet.action.wrapWithAbbreviation and abbreviation a.link and get the following result:

function MainLayout({ children }) {
  return (
    <div>
      <Header />
      {children}
      <a href=""><span>I want to be wrapped by the tag A with some className</span></a>
      <Footer />
    </div>
  );
}

Emmet didn't add the className link.

Expected result:

function MainLayout({ children }) {
  return (
    <div>
      <Header />
      {children}
      <a className='link' href=""><span>I want to be wrapped by the tag A with some className</span></a>
      <Footer />
    </div>
  );
}

NOTE: The same problem occurs in a HTML file too.

VS Code version: Code 1.56.0 (Universal) (cfa2e21, 2021-05-04T22:06:21.189Z)
OS version: Darwin x64 19.6.0

System Info
Item Value
CPUs Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz (4 x 2500)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 4
Memory (System) 8.00GB (0.33GB free)
Process Argv --disable-extensions --crash-reporter-id 83bbbd94-4239-471a-8b03-c15a5a28f289
Screen Reader no
VM 0%
Extensions disabled
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues labels May 10, 2021
@rzhao271 rzhao271 added this to the May 2021 milestone May 10, 2021
rzhao271 added a commit to rzhao271/emmet that referenced this issue May 11, 2021
@rzhao271 rzhao271 added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream labels May 11, 2021
@rzhao271 rzhao271 modified the milestones: May 2021, June 2021 May 21, 2021
@rzhao271 rzhao271 modified the milestones: June 2021, August 2021 Jun 25, 2021
@rzhao271 rzhao271 modified the milestones: August 2021, Backlog Aug 4, 2021
@rzhao271 rzhao271 modified the milestones: Backlog, On Deck, February 2022 Feb 11, 2022
rzhao271 added a commit to microsoft/vscode-emmet-helper that referenced this issue Feb 11, 2022
@rzhao271 rzhao271 added the upstream-issue-fixed The underlying upstream issue has been fixed label Feb 11, 2022
@mjbvz mjbvz added the verified Verification succeeded label Feb 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues insiders-released Patch has been released in VS Code Insiders upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@rzhao271 @mjbvz @iamrealmarsel and others