macOS Sierra: background artifacts

[maxence-charriere]

• VSCode Version: Code 1.5.2 (66f37fd, 2016-09-12T13:05:12.065Z)
• OS Version: Darwin x64 16.0.0

Steps to Reproduce:

1. just launch Visual studio on macOS Sierra

[maxence-charriere]

[bpasero]

@maxence-charriere can you try if this reproduces with our insider build too?
You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders

[maxence-charriere]

[maxence-charriere]

ok this one on Version 1.6.0-insider (1.6.0-insider):

[jaysylvester]

I'm seeing this as well.

Not sure if this helps, but I'm also seeing a similar problem in Chrome, which I submitted to them also. Screenshot below is Daring Fireball in Safari vs. Chrome:

[mrmlnc]

Hello, Chrome bug:

• Atom Dark Layout Issue on MacOS Sierra GM atom/atom#12634
• Weird Background Color electron/electron#7304

[bpasero]

Thanks for linking the related issues here. The related chrome bug is: https://bugs.chromium.org/p/chromium/issues/detail?id=633805

[bpasero]

@maxence-charriere @jaysylvester that issue talks about a possible fix using --force-gpu-rasterization, did you try that? maybe pass it to the starting of code?

[jaysylvester]

@bpasero Just tried --force-gpu-rasterization with VS Code and that fixes it.

[bpasero]

@jaysylvester great to hear that 👍

[maxence-charriere]

how to use it? I tried code --force-gpu-rasterization on the console but nothing changed.

[bpasero]

yeah, from the command line when launching an instance.

[l2dy]

/Applications/Visual\ Studio\ Code.app/Contents/MacOS/Electron --force-gpu-rasterization

[FabianLauer]

Since 1.6.0, I'm seeing some artifacts even with --force-gpu-rasterization.
Also, when setting "window.zoomLevel" to any value other than 0 the artifacts disappear, regardless of --force-gpu-rasterization.

[xgt001]

@FabianLauer Thanks, that did the trick for me!

[bpasero]

Todays VS Code insider build comes with Electron 1.6.x, would be interesting to hear if this update solves this issue for anyone: http://code.visualstudio.com/Download#insiders

[Codelica]

Thanks for the heads up!

Insider build fixed it for me without any workarounds. 👍

(Using a calibrated i1 color profile)

[jfieber]

It does. The colors are substantially different than before. Side by side with the same theme, the insider version colors are way more saturated.

[bpasero]

Awesome 👍

[biscoffCity]

didn't work. Had to set"window.zoomLevel": 0.001 and I still see screen flickers.

[bpasero]

@am6377 are you on our insiders build?

[biscoffCity]

I was on insider build and then I switched to normal build to see if there was any difference and for me there isn't.

…

On Monday, April 17, 2017, Benjamin Pasero ***@***.***> wrote: @am6377 <https://github.com/am6377> are you on our insiders build? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12473 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKWiGfQBdnWqhCv_Jj-64gYoYNTTiNqdks5rw4pagaJpZM4KEMxM> .

[bpasero]

So it looks like the Electron update is only resolving it for some people.

[epogue]

@bpasero The Insiders update fixed the issue for me. No need for the zoomLevel hack now.

[biscoffCity]

@bpasero I tried #insider build but I can't use custom or other built-in display profile except for the standard color LCD which actually doesn't look really nice IRL. The only way it works for me is setting "window.zoomLevel": 0.001 and even with that I get lots of random screen flickers.

[jfieber]

With the current insiders build, using that specific profile (ITU-R BT.709-6), and the default dark theme, I'm not seeing the behavior, either on the built in display (5k iMac) or external display. With the current non-insiders build, I initially thought the window.zoomLevel hack worked, but after using it for awhile, it was clear that it helped some, but didn't eliminate the issue.

[bpasero]

The issue is resolved for me, I just verified that. No clue why some people are still seeing it though when trying our insiders build.

[Codelica]

It fixed all 3 machines I use which have custom profiles. Purely a guess, but maybe some people are downloading the normal version from the link posted (https://code.visualstudio.com/Download#insiders), not realizing the Insiders build is a text link at the bottom.

[bpasero]

Yeah, sounds like it.

[biscoffCity]

I would like to apologize to @bpasero and I would like to thank @Codelica because I realized I didn't download the insiders build. I thought the link with #insiders took to me to the insiders built. I didn't scroll down. The direct link to insiders is
(https://code.visualstudio.com/insiders) WITHOUT the #
My fault :)

[will-stone]

Came across this issue when scratching my head that the background colour I was setting in my theme was showing differently on the screen (i.e. when checking it with the Digital Color Meter). I did download the Insiders build and I can confirm it's fixed there for me. Can I ask when this fix will roll out? Theming is feeling rather futile while my colours don't match :-(