Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hot Exit: Support hot exit on empty workspaces #13733

Closed
Tyriar opened this issue Oct 14, 2016 · 3 comments · Fixed by #16303
Closed

Hot Exit: Support hot exit on empty workspaces #13733

Tyriar opened this issue Oct 14, 2016 · 3 comments · Fixed by #16303
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality workbench-hot-exit Preservation of unsaved changes across restarts
Milestone
Backlog

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 14, 2016

Hot exit (#101) should work on empty workspaces (those with no opened folder).
@Tyriar Tyriar added feature-request Request for new features or functionality file-explorer Explorer widget issues labels Oct 14, 2016
@Tyriar Tyriar self-assigned this Oct 14, 2016
@Tyriar Tyriar mentioned this issue Oct 14, 2016
Merged
23 tasks
@Tyriar Tyriar added workbench-hot-exit Preservation of unsaved changes across restarts workbench and removed file-explorer Explorer widget issues labels Oct 14, 2016
@Tyriar Tyriar mentioned this issue Oct 22, 2016
Closed
@Tyriar Tyriar modified the milestone: Backlog Nov 1, 2016
@Tyriar Tyriar mentioned this issue Nov 4, 2016
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Nov 4, 2016

Restoring files in empty workspaces is probably a pre-requisite to this: #207

@Tyriar Tyriar removed the workbench label Nov 4, 2016
@Tyriar Tyriar mentioned this issue Nov 29, 2016
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Dec 1, 2016

I looked into Electron's window ID, looks like it's 0 and incremented each time so we wouldn't be able to use that as a (empty) window identifier across sessions.

Tyriar added a commit that referenced this issue Dec 1, 2016
@Tyriar
Rough initial empty workspace hot exit impl
5517e6f 
Part of #13733
@Tyriar Tyriar mentioned this issue Dec 1, 2016
Merged
@rsenna
Copy link

rsenna commented Jun 21, 2017 •
edited
Loading

Not working for me when multiple windows open.

The first window hasa open folder, the second with no folder opened.
When I create a new document into the second window, and thenI close it, VSCode warns me that I'll lose changes if I not save them.

That still happens even with "files.hotExit": "onExitAndWindowClose" in my preferences file.
(Windows 10 Professional, VSCode 1.13.1)

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality workbench-hot-exit Preservation of unsaved changes across restarts
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Hot exit empty workspace support microsoft/vscode
2 participants
@rsenna @Tyriar