Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There's a rerun command action in shell integration menu for finite task #153451

Closed
alexr00 opened this issue Jun 28, 2022 · 1 comment · Fixed by #153548
Closed

There's a rerun command action in shell integration menu for finite task #153451

alexr00 opened this issue Jun 28, 2022 · 1 comment · Fixed by #153548
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Milestone
June 2022

Comments

@alexr00
Copy link
Member

alexr00 commented Jun 28, 2022

Testing #153365

Finite tasks IE ones that start and stop
...

  • there's no Rerun command action in the context menu
  1. Open microsoft/vscode folder
  2. Tasks: Run Task -> npm -> npm: compile
  3. Wait for task to complete then scroll up to the top of the task to see the shell integration decoration.
  4. There's a "Rerun Commmand" action there.
    image
@alexr00
Copy link
Member Author

alexr00 commented Jun 28, 2022

I also tried adding a problem matcher, but "rerun command" action was still there.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug tasks Task system issues terminal-shell-integration Shell integration infrastructure, command decorations, etc. labels Jun 28, 2022
@Tyriar Tyriar added this to the June 2022 milestone Jun 28, 2022
Tyriar added a commit that referenced this issue Jun 28, 2022
@Tyriar
Fix OSC 633 P format in tasks
8d23eee 
Fixes #153451
@Tyriar Tyriar mentioned this issue Jun 28, 2022
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 28, 2022
@alexr00 alexr00 added the verified Verification succeeded label Jun 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

Fix OSC 633 P format in tasks microsoft/vscode
4 participants
@Tyriar @meganrogge @alexr00 @vscodenpa