Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task POI navigation UX is confusing #153591

Closed
sbatten opened this issue Jun 28, 2022 · 5 comments · Fixed by #155626
Closed

Task POI navigation UX is confusing #153591

sbatten opened this issue Jun 28, 2022 · 5 comments · Fixed by #155626
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal-shell-integration Shell integration infrastructure, command decorations, etc. ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@sbatten
Copy link
Member

sbatten commented Jun 28, 2022

Testing #153365

When I use cmd+up/down to navigate between POIs in task output, the blue box renders for a second on the item I have selected, but then disappears. I didn't understand what was happening to the focus border.

@meganrogge
Copy link
Contributor

that is by design.

@Tyriar
Copy link
Member

Tyriar commented Jun 28, 2022

This has come up before, @misolori I think you had an idea to improve this?

@Tyriar Tyriar added this to the July 2022 milestone Jun 28, 2022
@Tyriar Tyriar added tasks Task system issues ux User experience issues terminal-shell-integration Shell integration infrastructure, command decorations, etc. labels Jun 28, 2022
@miguelsolorio
Copy link
Contributor

I had the same experience in #145801 where I was on a slow machine. I think I had suggested just using a line on the side (like our activity bar) that remains until your focus changes:

@Tyriar
Copy link
Member

Tyriar commented Jul 12, 2022

To the left of the command decorations?

image

I like how visible the outline is when jumping between commands, so we could keep that as is and just also show the persistent line?

image

@Tyriar Tyriar added the feature-request Request for new features or functionality label Jul 12, 2022
@miguelsolorio
Copy link
Contributor

yea I'd be open to trying that out, I think using both might be a bit overkill but just having the single line can also be hard to notice.

Tyriar added a commit that referenced this issue Jul 19, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 19, 2022
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Jul 22, 2022
@connor4312 connor4312 added the verified Verification succeeded label Jul 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal-shell-integration Shell integration infrastructure, command decorations, etc. ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants