Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The label First Error is uninformative and kind of confusing #153600

Closed
sbatten opened this issue Jun 28, 2022 · 9 comments · Fixed by #153606
Closed

The label First Error is uninformative and kind of confusing #153600

sbatten opened this issue Jun 28, 2022 · 9 comments · Fixed by #153606
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue tasks Task system issues terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Milestone

Comments

@sbatten
Copy link
Member

sbatten commented Jun 28, 2022

Testing #153365

@Tyriar
Copy link
Member

Tyriar commented Jun 28, 2022

@sbatten what would you expect it to say?

@sbatten
Copy link
Member Author

sbatten commented Jun 28, 2022

I'm not sure exactly. something more verbose like "Beginning of list of errors in output"

@Tyriar
Copy link
Member

Tyriar commented Jun 28, 2022

How about "Beginning of detected errors for this run"? Can't use something more natural like "compile" or "tests" as a watch/background task could be doing anything

@Tyriar Tyriar added this to the June 2022 milestone Jun 28, 2022
@sbatten
Copy link
Member Author

sbatten commented Jun 28, 2022

yea i think that's better. yea i started to see the challenge when thinking about it and the fact that it needs to be pretty generic

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug tasks Task system issues polish Cleanup and polish issue terminal-shell-integration Shell integration infrastructure, command decorations, etc. labels Jun 28, 2022
meganrogge added a commit that referenced this issue Jun 28, 2022
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jun 28, 2022
@karthiknadig
Copy link
Member

I am a bit late for this, but what is the reason for the first error message label?

@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 29, 2022
@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2022

@karthiknadig it's a marker in the buffer so you can quickly jump to it via ctrl/cmd+up, this is more useful in tests when using verbose assertions.

@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2022

Example:

Recording 2022-06-29 at 03 29 32

@joyceerhl joyceerhl added the verified Verification succeeded label Jun 30, 2022
@joyceerhl
Copy link
Collaborator

I'm a little confused about the luminance of the decorations I'm seeing for watch tasks, how is it determined? All three of the following decorations for various problems in a watch task got the same label:

image
image
image

@meganrogge
Copy link
Contributor

there are some issues on windows with the decorations when the terminal gets resized. it looks like a few decorations are getting overlaid in your first and last image #153476

@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue tasks Task system issues terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants