Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task shell integration cannot be disabled #153812

Closed
jeanp413 opened this issue Jun 30, 2022 · 3 comments · Fixed by #153851
Closed

Task shell integration cannot be disabled #153812

jeanp413 opened this issue Jun 30, 2022 · 3 comments · Fixed by #153851
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Milestone
June 2022

Comments

@jeanp413
Copy link
Contributor

  • VS Code Version: insiders/from sources

Task terminals don't respect "terminal.integrated.shellIntegration.enabled" setting so decorations cannot be disabled.
@jeanp413 jeanp413 mentioned this issue Jun 30, 2022
Closed
3 tasks
@meganrogge meganrogge assigned Tyriar and meganrogge and unassigned rebornix Jun 30, 2022
@meganrogge
Copy link
Contributor

thanks for creating this issue. I remember noticing this then got distracted by some other issue 😓

@meganrogge meganrogge added tasks Task system issues terminal-shell-integration Shell integration infrastructure, command decorations, etc. and removed triage-needed labels Jun 30, 2022
@meganrogge meganrogge added this to the June 2022 milestone Jun 30, 2022
@meganrogge meganrogge added the bug Issue identified by VS Code Team member as probable bug label Jun 30, 2022
@meganrogge
Copy link
Contributor

meganrogge commented Jun 30, 2022 •
edited
Loading

we're separating the task decorations from terminal decorations (shell integration), so will have a task.showDecorations setting

meganrogge added a commit that referenced this issue Jun 30, 2022
@meganrogge
fix #153812
2d3c9d6
@meganrogge meganrogge mentioned this issue Jun 30, 2022
Merged
meganrogge added a commit that referenced this issue Jun 30, 2022
@meganrogge
add task.showDecorations setting (#153851)
88ffbc7 
fix #153812
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 30, 2022
@aeschli
Copy link
Contributor

aeschli commented Jul 1, 2022

Verified that task.showDecorations works

@aeschli aeschli added the verified Verification succeeded label Jul 1, 2022
@tamuratak tamuratak mentioned this issue Jul 30, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal-shell-integration Shell integration infrastructure, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

add task.showDecorations setting microsoft/vscode
6 participants
@rebornix @Tyriar @aeschli @jeanp413 @meganrogge @vscodenpa