Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll out new diff algorithm #184900

Closed
hediet opened this issue Jun 12, 2023 · 0 comments · Fixed by #188474
Closed

Roll out new diff algorithm #184900

hediet opened this issue Jun 12, 2023 · 0 comments · Fixed by #188474
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@hediet
Copy link
Member

hediet commented Jun 12, 2023

The new diff algorithm is 70% slower than the current one, but provides better results. 95% percentile is 600ms, which is fine.
50% of stable users already use the new diff algorithm.

Potential blockers:

See also:

Verification steps:

  • Go to settings and verify the default of "diffEditor.algorithm" is "advanced"
@hediet hediet added feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming labels Jun 12, 2023
@hediet hediet added this to the June 2023 milestone Jun 12, 2023
@hediet hediet self-assigned this Jun 12, 2023
@hediet hediet modified the milestones: June 2023, July 2023 Jun 27, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 21, 2023
@hediet hediet added the verification-needed Verification of issue is requested label Jul 25, 2023
@alexr00 alexr00 added the verified Verification succeeded label Jul 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants