Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt new DOM renderer performance changes #189405

Closed
Tyriar opened this issue Aug 1, 2023 · 2 comments · Fixed by #189430
Closed

Adopt new DOM renderer performance changes #189405

Tyriar opened this issue Aug 1, 2023 · 2 comments · Fixed by #189430
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 1, 2023

Upstream: xtermjs/xterm.js#4605
@Tyriar Tyriar added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream terminal-rendering labels Aug 1, 2023
@Tyriar Tyriar added this to the August 2023 milestone Aug 1, 2023
@Tyriar Tyriar self-assigned this Aug 1, 2023
Tyriar added a commit that referenced this issue Aug 1, 2023
@Tyriar
[email protected]
a52b379 
Fixes #189403
Fixes #189405
@Tyriar Tyriar mentioned this issue Aug 1, 2023
Merged
@Tyriar Tyriar added the upstream-issue-fixed The underlying upstream issue has been fixed label Aug 1, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 1, 2023
@kieferrm kieferrm mentioned this issue Aug 6, 2023
Closed
65 tasks
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Aug 28, 2023
@connor4312
Copy link
Member

@Tyriar are there steps for this?

@connor4312 connor4312 added the verification-steps-needed Steps to verify are needed for verification label Aug 29, 2023
@Tyriar
Copy link
Member Author

Tyriar commented Aug 29, 2023

To verify set gpuAcceleration to off and run a few commands.

@Tyriar Tyriar removed the verification-steps-needed Steps to verify are needed for verification label Aug 29, 2023
@connor4312 connor4312 added the verified Verification succeeded label Aug 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2023
Development

Successfully merging a pull request may close this issue.

[email protected] microsoft/vscode
3 participants
@Tyriar @connor4312 @vscodenpa