Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more cursor styles #1929

Closed
alexdima opened this issue Jan 11, 2016 · 14 comments
Closed

Add more cursor styles #1929

alexdima opened this issue Jan 11, 2016 · 14 comments
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors
Milestone

Comments

@alexdima
Copy link
Member

Extracted from #1586.
Related: #200.

block/block-thin/block-hollow/block-outline:

block-outline

? {
    background: transparent;
    border: 1px solid;
    box-sizing: border-box;
    position: absolute;
    width: 1ch;
    cursor: text;
}

block/block-filled:

block-filled

? {
    position: absolute;
    width: 1ch;
    cursor: text;
}

line/line-thin/line-narrow:

line-thin

? {
    position: absolute;
    width: 1px;
    cursor: text;
}

line/line-thick/line-accessible:

line-thick

? {
    position: absolute;
    width: 2px;
    cursor: text;
}

underline/underline-thin:

underline-thin

? {
    background: transparent;
    border-bottom: 1px solid;
    box-sizing: border-box;
    position: absolute;
    width: 1ch;
    cursor: text;
}

underline/underline-thick/underline-accessible:

underline-thick

? {
    background: transparent;
    border-bottom: 2px solid;
    box-sizing: border-box;
    position: absolute;
    width: 1ch;
    cursor: text;
}

I'm not too sure about the names, maybe:

block-filled
block-outline
line-thin
line-thick
underline-thin
underline-thick

... I'll leave this to the developers. =)

cc @glen-84 @markrendle

@alexdima alexdima added the feature-request Request for new features or functionality label Jan 11, 2016
@alexdima alexdima added this to the Backlog milestone Jan 11, 2016
@ThatRendle
Copy link
Contributor

I have got the code for these, I'll create a PR for them.

@glen-84
Copy link

glen-84 commented Jan 12, 2016

Awesome, thanks @markrendle =)

@jpoon
Copy link

jpoon commented Feb 18, 2016

@alexandrudima. I think this PR #1586 closes this issue.

@glen-84
Copy link

glen-84 commented Feb 18, 2016

@jpoon This issue is about additional cursor styles.

@ghost
Copy link

ghost commented May 17, 2016

ok, where do I define these styles?

@glen-84
Copy link

glen-84 commented May 21, 2016

@andysaini What exactly are you asking? Are you wanting to submit a PR?

@ghost
Copy link

ghost commented May 22, 2016

@glen-84 no, how do I apply these styles to vscode?

@glen-84
Copy link

glen-84 commented May 22, 2016

I don't think that you can, at least not permanently. #459 would probably help.

@alexdima alexdima added good first issue Issues identified as good for first-time contributors editor-core Editor basic functionality labels Aug 30, 2016
@alexdima
Copy link
Member Author

PR welcome!

  • relevant existing cursor style enum: TextEditorCursorStyle
  • relevant existing cursor style css: viewCursors.css > .monaco-editor .cursors-layer.cursor-block-style etc

Swiiip added a commit to Swiiip/vscode that referenced this issue Dec 16, 2016
New styles:
  - line (default)
  - line-thin
  - block
  - block-outline
  - underline
  - underline-thin

Linked to Feature request: microsoft#1929
Swiiip added a commit to Swiiip/vscode that referenced this issue Jan 4, 2017
New styles:
  - line (default)
  - line-thin
  - block
  - block-outline
  - underline
  - underline-thin

Linked to Feature request: microsoft#1929
@harryio
Copy link

harryio commented Feb 2, 2017

disappointed that this was not included in the 1.9 release ..

@navxio
Copy link

navxio commented Feb 9, 2017

despite it being a beginner level issue, no resolution yet

@alexdima alexdima added this to the February 2017 milestone Feb 20, 2017
@alexdima alexdima removed this from the Backlog milestone Feb 20, 2017
@alexdima
Copy link
Member Author

Merged via #14237, thank you @Swiiip

@allexon
Copy link

allexon commented Feb 25, 2017

Hello, I'm using vscode a little while, really cool, now if anyone can help me with a situation. The visual code put some white borders in markup tags like [(<{.... these edges are annoying these edges, does anyone know how I do to remove them, see the image as an example
bordas

@glen-84
Copy link

glen-84 commented Feb 26, 2017

@allexon #13379

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors
Projects
None yet
Development

No branches or pull requests

7 participants