Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot scroll in terminal window created by api until resize #20505

Closed
DonJayamanne opened this issue Feb 12, 2017 · 10 comments
Closed

Cannot scroll in terminal window created by api until resize #20505

DonJayamanne opened this issue Feb 12, 2017 · 10 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

From @hun1ahpu on February 12, 2017 10:22

Environment data

VS Code version: 1.9.1
Python Extension version: 0.5.8
Python Version: 3
OS and version: win 10

Actual behavior

Mouse wheel scroll doesn't work
Scroll bar is not visible
After resizing the terminal window it starts working

Steps to reproduce:

  • Open any python file and execute any line of it

pythonscrollbar

Copied from original issue: DonJayamanne/pythonVSCode#739

@Tyriar Tyriar changed the title Cannot scroll in terminal window Cannot scroll in terminal window created by api until resize Feb 13, 2017
@Tyriar Tyriar self-assigned this Feb 13, 2017
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Feb 13, 2017
@Tyriar Tyriar added this to the February 2017 milestone Feb 13, 2017
@Tyriar Tyriar modified the milestones: February 2017, Backlog Feb 21, 2017
@daviwil
Copy link
Contributor

daviwil commented Apr 5, 2017

Ahhh! I'm seeing this too in the PowerShell extension. I thought it was something I was doing wrong :)

@jsk01
Copy link

jsk01 commented May 5, 2017

The scrollbar now seems to work correctly in the insiders build when using powershell.

@Tyriar
Copy link
Member

Tyriar commented May 5, 2017

@jsk01 this bug was a little flaky, I don't think any changes were made in this area.

@gandhis1
Copy link

gandhis1 commented May 10, 2017

Strangely enough, I used to not get this bug, but now I do on the latest official release. I get this behavior with a Python file that is executing in the terminal - I cannot use the mouse scroll button to scroll the terminal, nor is there a scroll bar that I can click on available. However, once I use the resize arrow or actually drag to resize, the scrolling begins to work. It's quite annoying

@stayfool
Copy link

This problem is ok in windows 10.

@KillyMXI
Copy link
Contributor

KillyMXI commented May 22, 2017

Windows 10 Pro (v 1607), VS Code 1.12.2

The issue still exists.
The first opened terminal works as intended (with scroll). All the next terminal sessions will have no scroll until resized or VSCode restarted.

@shmutalov
Copy link

shmutalov commented Jul 9, 2017

Very annoying issue -_-
VSCode 1.13.1, Windows 10 x64
https://www.youtube.com/watch?v=6ZsStclrirg

@chrmarti chrmarti self-assigned this Jul 10, 2017
@chrmarti
Copy link
Collaborator

@Tyriar Can reproduce with Python's 'Run Selection' command on Windows. Logging this.charMeasure.height in Viewport.refresh() shows that charMeasure isn't initialized in time.

@Tyriar
Copy link
Member

Tyriar commented Jul 12, 2017

Sat together with @chrmarti yesterday to figure this thing out, the fix for this is coming in 1.15 🎉

It was an obscure bug that was happening when the terminal was created before the panel was shown. It was caused by eb85ea8 to fix #22328. The reason is because since we were not setting the pty and xterm.js to the correct size before the terminal existed, xterm.js didn't bother doing a proper resize and the adjustments necessary (like re-measuring the character size) here https://github.com/sourcelair/xterm.js/blob/85c892c218c5529efd01569b7dc9b1123ae53582/src/xterm.js#L1942

@shmutalov
Copy link

@Tyriar good to hear that 🐱

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

10 participants