Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs ability to provide "user css" #21798

Closed
jsumners opened this issue Mar 2, 2017 · 8 comments
Closed

Needs ability to provide "user css" #21798

jsumners opened this issue Mar 2, 2017 · 8 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@jsumners
Copy link

jsumners commented Mar 2, 2017

  • VSCode Version: 1.10.0
  • OS Version: macOS 10.12.3

PR #14237 added a style that I have been eagerly waiting for. However, now that it has been released, it's still unusable for me. I have a theme installed that I like except for the styling around the cursor (.monaco-editor .cursors-layer.cursor-block-outline-style > .cursor). So the reasonable assumption would be that I can override that style with my own styling. But that isn't the case; vscode doesn't provide any way to specify user styles., e.g. in Atom select "Stylesheet..." from the Atom menu.

@balupton
Copy link

balupton commented Mar 3, 2017

I wish this was provided as it would solve these things:

  1. Fixing font rendering for me: Provide an option to enable DirectWrite #1896 (comment)

  2. Overriding theme values - such as a background colour.

  3. Customising git gutter - FR: customise git gutter styling #21853

@hoovercj
Copy link
Member

hoovercj commented Mar 3, 2017

Duplicate of the still open #11556 and #459

Similar closed issues:
#13732
#3570
#9004

@isidorn
Copy link
Contributor

isidorn commented Mar 3, 2017

Closing as duplicate
Thanks @hoovercj

@isidorn isidorn closed this as completed Mar 3, 2017
@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 3, 2017
@jsumners
Copy link
Author

jsumners commented Mar 3, 2017

So for at least a year people have been saying this feature is needed and no one has bothered?

@shalldie
Copy link

So far, i want to custom my self css for a long long long time.

Man who agree with me? give me a 👍

@hoovercj
Copy link
Member

@shalldie I believe the team has said elsewhere (and they'll correct me if I'm wrong) that they would prefer to avoid user css as it can prevent them from iterating on the underlying Dom structure to avoid breaking custom css. They want each api they release to be stable and long lived, and that doesn't work with custom css.

@jsumners
Copy link
Author

That's a load of garbage. The issue at hand would allow overriding a theme's CSS with user preferences. If it works in a theme, what would the difference be in applying another stylesheet on top of it?

@hoovercj
Copy link
Member

@jsumners Theme overrides are tracked in this issue #27894 and I have a PR for it here #29393

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

5 participants