Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not detecting language for PHP files using shebang #26580

Closed
mappu opened this issue May 13, 2017 · 0 comments · Fixed by #26581
Closed

Not detecting language for PHP files using shebang #26580

mappu opened this issue May 13, 2017 · 0 comments · Fixed by #26581
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues verified Verification succeeded
Milestone
May 2017

Comments

@mappu
Copy link
Contributor

mappu commented May 13, 2017

  • VSCode Version: 1.12.1
  • OS Version: debian stretch

Steps to Reproduce:

  1. Open file with #!/usr/bin/php shebang header but not .php extension
  2. File is not detected as PHP code, instead uses 'Plain Text' highlighter

It should be easy to fix in vscode/extensions/php/package.json adding a firstLine property, as is done for e.g. Python.
mappu added a commit to mappu/vscode that referenced this issue May 13, 2017
@mappu
extension/php: detect language via shebang
a95ad4c 
Fixes microsoft#26580
@mappu mappu mentioned this issue May 13, 2017
Merged
mjbvz pushed a commit that referenced this issue May 13, 2017
@mappu @mjbvz
extension/php: detect language via shebang (#26581)
092ea70 
Fixes #26580
@mjbvz mjbvz self-assigned this May 13, 2017
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label May 13, 2017
@mjbvz mjbvz added this to the May 2017 milestone May 13, 2017
@mjbvz mjbvz added the languages-basic Basic language support issues label May 13, 2017
marckassay pushed a commit to marckassay/vscode that referenced this issue May 15, 2017
@mappu @marckassay
extension/php: detect language via shebang (microsoft#26581)
5f00cb1 
Fixes microsoft#26580
@roblourens roblourens added the verified Verification succeeded label Jun 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues verified Verification succeeded
Projects
None yet
Milestone
May 2017
Development

Successfully merging a pull request may close this issue.

extension/php: detect language via shebang mappu/vscode
3 participants
@roblourens @mappu @mjbvz