Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation of active line number color #46732

Closed
svipas opened this issue Mar 27, 2018 · 4 comments
Closed

Documentation of active line number color #46732

svipas opened this issue Mar 27, 2018 · 4 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Milestone
March 2018

Comments

@svipas
Copy link
Contributor

svipas commented Mar 27, 2018

This color was introduced in 1.21: https://code.visualstudio.com/updates/v1_21#_coloring-of-active-line-number and it's missing in theme color reference: https://code.visualstudio.com/docs/getstarted/theme-color-reference
@vscodebot
Copy link

vscodebot bot commented Mar 27, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@svipas svipas changed the title Coloring of active line Coloring of active line number Mar 27, 2018
@vscodebot vscodebot bot added the themes Color theme issues label Mar 27, 2018
@aeschli
Copy link
Contributor

aeschli commented Mar 28, 2018

Added doc.

Note, I just fixed #46848, so the color is now named editorLineNumber.activeForeground

@aeschli aeschli added this to the March 2018 milestone Mar 28, 2018
aeschli added a commit to microsoft/vscode-docs that referenced this issue Mar 28, 2018
@aeschli
Coloring of active line number. Fixes microsoft/vscode#46732
d72772c
@svipas
Copy link
Contributor Author

svipas commented Mar 28, 2018

@aeschli Thank you very much, I guess it can be closed?

@aeschli aeschli closed this as completed Mar 28, 2018
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Mar 29, 2018
@aeschli aeschli changed the title Coloring of active line number Documentation of active line number color Mar 29, 2018
@Tyriar
Copy link
Member

Tyriar commented Mar 29, 2018

Verified via code review

@Tyriar Tyriar added the verified Verification succeeded label Mar 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
March 2018
Development

No branches or pull requests
3 participants
@Tyriar @aeschli @svipas