-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: download and upload in explorer in web #83225
Comments
Everything else seems good. Downloads of big files and multiple files work, contents are OK, single file uploads are OK. |
|
@connor4312 @eamodio can you maybe coordinate and report a bunch of individual issues? Then we can continue from there. Quick feedback:
I think being able to drop a file into the editor area to open it would be nice, but not sure how to do that because we would almost have to create a temporary file on the remote to open it. Not sure if disabling the drop target is possible either because we still want the DND feedback when dragging from the file explorer inside VSCode. |
Erg, yea, that's a pain. It's possible to attach multiple Files to the drag event, but these object must be created with some binary sequence--they don't support streams--so you'd need to have the file contents at hand, loaded into memory, to actually support that. I'm guessing that's why Chrome implemented the non-standard downloadUrl 😛 I'll work with Eric to get some issues opened for the other points. |
I think its fine, for multi-download we offer a command in the file explorer context menu that works with multi-select. |
Refs: #83037
Complexity: 2
The text was updated successfully, but these errors were encountered: