Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: download and upload in explorer in web #83225

Closed
2 tasks done
bpasero opened this issue Oct 24, 2019 · 5 comments
Closed
2 tasks done

Test: download and upload in explorer in web #83225

bpasero opened this issue Oct 24, 2019 · 5 comments

Comments

@bpasero
Copy link
Member

bpasero commented Oct 24, 2019

Refs: #83037

Complexity: 2

  • Using the web UI, right click on file(s) from the explorer and verify you can trigger a download and that the contents are OK.
  • Also verify that you can drag multiple files from your desktop to the web UI. Make sure that they get uploaded properly and that the content is correct. Make sure that you get a confirmation dialog in case of a name clash.
  • Drag a file onto the desktop and verify it gets downloaded there
@bpasero bpasero added this to the October 2019 milestone Oct 24, 2019
@isidorn isidorn changed the title Test: download from explorer in web Test: download adn upload in explorer in web Oct 24, 2019
@isidorn isidorn changed the title Test: download adn upload in explorer in web Test: download and upload in explorer in web Oct 24, 2019
@connor4312
Copy link
Member

connor4312 commented Oct 29, 2019

  • Dragging multiple files to the desktop on OSX doesn't appear to work. Only one file is downloaded.
  • One edge case I did find is that if, on OSX, I have a file with a colon in its path like weird:name.json, when downloaded its name is weird_name.json
  • Dragging a folder in to be uploaded didn't appear to do anything. If we don't support that at the moment, maybe we should show a message.
  • I tried to upload a 5GB file, but that didn't appear to do anything.

Everything else seems good. Downloads of big files and multiple files work, contents are OK, single file uploads are OK.

@eamodio
Copy link
Contributor

eamodio commented Oct 29, 2019

  • Dragging multiple files into the vscode explorer works fine on Windows, although if there name conflicts in the set of files you are dragging, you will get a confirmation dialog for each of them, but there isn't any way to tell which file conflicted so at first I thought the confirmation dialog wasn't working, but in reality it was, I was just cancelling each of the conflicts one by one. We probably should add the file name in that confirmation dialog.

  • Like @connor4312 above, dragging multiple files to the desktop on Windows doesn't work. Only the first file is downloaded.

  • Again same as @connor4312, dragging folders in or out on Windows doesn't do anything. EDIT: Apparently dragging a folder out of vscode, did do something -- it just took a LONG time and failed with Couldn't download - Network Issue.

  • I tried dragging a file into the editor area (like you can on desktop) and expected the file to be opened in a new tab. But nothing happens. If this isn't going to be supported we maybe should disable the drop target.

  • I also kind of expected to be able to right-click download from a folder as well.

@bpasero
Copy link
Member Author

bpasero commented Oct 29, 2019

@connor4312 @eamodio can you maybe coordinate and report a bunch of individual issues? Then we can continue from there. Quick feedback:

  • multiple file download is nothing we can support currently when using drag and drop, at least I am not aware of a way to do this with Chromes DownloadURL type

I think being able to drop a file into the editor area to open it would be nice, but not sure how to do that because we would almost have to create a temporary file on the remote to open it. Not sure if disabling the drop target is possible either because we still want the DND feedback when dragging from the file explorer inside VSCode.

@connor4312
Copy link
Member

multiple file download is nothing we can support currently when using drag and drop, at least I am not aware of a way to do this with Chromes DownloadURL type

Erg, yea, that's a pain. It's possible to attach multiple Files to the drag event, but these object must be created with some binary sequence--they don't support streams--so you'd need to have the file contents at hand, loaded into memory, to actually support that. I'm guessing that's why Chrome implemented the non-standard downloadUrl 😛 I'll work with Eric to get some issues opened for the other points.

@bpasero
Copy link
Member Author

bpasero commented Oct 30, 2019

I think its fine, for multi-download we offer a command in the file explorer context menu that works with multi-select.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants