Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Support a Download action on folder context menus in explorer #83579

Closed
eamodio opened this issue Oct 29, 2019 · 5 comments
Closed

Web: Support a Download action on folder context menus in explorer #83579

eamodio opened this issue Oct 29, 2019 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan web Issues related to running VSCode in the web
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Oct 29, 2019

  • VSCode Version: 1.40.0-insider @ b7b2184
  • OS Version: Windows 10 (1903)

It would be nice to support a Download option for folders in the explorer just like with files.

Ref: #83225

@eamodio eamodio added feature-request Request for new features or functionality web Issues related to running VSCode in the web labels Oct 29, 2019
@eamodio eamodio changed the title Web: Support _Download_ action on folder context menu in explorer Web: Support a Download action on folder context menus in explorer Oct 29, 2019
@bpasero bpasero added the file-explorer Explorer widget issues label Oct 30, 2019
@bpasero bpasero removed their assignment Oct 30, 2019
@bpasero bpasero added this to the Backlog milestone Oct 30, 2019
@bpasero
Copy link
Member

bpasero commented Feb 1, 2020

@Chuxel
Copy link
Member

Chuxel commented Sep 14, 2020

@bpasero I think this is starting to become a bit of an issue. Has there been any investigations here? Rather than using native fs APIs, couldn't we just zip and return a single file?

@bpasero
Copy link
Member

bpasero commented Sep 14, 2020

Has there been any investigations here

None that lead to a conclusion I would say.

Rather than using native fs APIs, couldn't we just zip and return a single file?

We would need to use a third party library for this purpose, as there is no built in zip support in node.js for multi-file archives. We already have some usage of such a library in core (I think to extract extensions) so I think it is doable. Probably needs a bit of investigation if we can do it in a clever way that involves streams and not requires all of the files to be compressed in-memory or even to disk.

@bpasero bpasero assigned bpasero and unassigned isidorn Oct 19, 2020
@bpasero bpasero modified the milestones: Backlog, October 2020 Oct 19, 2020
@bpasero
Copy link
Member

bpasero commented Oct 19, 2020

Leveraging new Chrome/Edge file system access API (https://wicg.github.io/file-system-access/) to support downloading folders or large files.

@isidorn
Copy link
Contributor

isidorn commented Oct 19, 2020

Very cool 👏

@bpasero bpasero added on-testplan on-release-notes Issue/pull request mentioned in release notes labels Oct 24, 2020
jmannanc pushed a commit to jmannanc/vscode that referenced this issue Oct 26, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan web Issues related to running VSCode in the web
Projects
None yet
Development

No branches or pull requests

5 participants
@Chuxel @eamodio @bpasero @isidorn and others