-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt extension kind for those extensions defined as ui extensions #85819
Comments
This was referenced Nov 29, 2019
roblourens
added a commit
to roblourens/vscode-edge-debug2
that referenced
this issue
Nov 29, 2019
roblourens
added a commit
to microsoft/vscode-chrome-debug
that referenced
this issue
Nov 30, 2019
aeschli
added a commit
that referenced
this issue
Dec 2, 2019
@chrmarti Correct me if I'm wrong, but the Azure Account Extension is currently a workspace extension and various other workspace extensions depend on it (Docker, Azure functions). Since it doesn't set |
Ping @chrisdias and @mjbvz for pending adoptions |
I already adopted this in the image-preview with b0fb9f1 |
done |
Great. Thanks guys. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Adoption for #85036
Background
extensionKind
attribute can be an array, pls see the documentation.string
type forextensionKind
property in favour ofstring array
type to cause less confusions and the newextensionKind
must be adopted.Adoption
If you have an extension with the
extensionKind
set to"ui"
, then you must change the extension kind to:resolver
can only run locally.Details about the New Format & Behaviour
["ui"]: Runs only locally.
["workspace"]: Runs only remotely.
["ui", "workspace"]: Preferably runs locally if exists otherwise can run remotely.
["workspace", "ui"]: Preferably runs remotely if exists otherwise can run locally.
Adoption Tracking
Please go through the extensions listed below and adopt your extension to use the new array format correctly as per above table.
git-ui
- @chrmartiimage-preview
- @mjbvzms-vscode-remote.remote-containers
["ui"]- @chrmartims-vscode-remote.remote-ssh-edit
["ui"]- @roblourensms-vscode-remote.remote-ssh
["ui"]- @roblourensms-vscode-remote.remote-wsl
["ui"]- @aeschlims-vscode-remote.vscode-remote-extensionpack
["ui"] - @roblourens @aeschli @chrmartims-vscode.notepadplusplus-keybindings
["ui", "workspace"] - @chrisdiasms-vscode.sublime-keybindings
["ui", "workspace"] - @chrisdiasmsjsdiag.debugger-for-chrome
["ui"] - @roblourensmsjsdiag.debugger-for-edge
["ui"] - @roblourensvscode-test-resolver
["ui"] - @aeschli@alexandrudima FYI
The text was updated successfully, but these errors were encountered: