Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcards on activationEvents.workspaceContains? #944

Closed
ghost opened this issue Dec 2, 2015 · 4 comments
Closed

Wildcards on activationEvents.workspaceContains? #944

ghost opened this issue Dec 2, 2015 · 4 comments
Assignees
Labels
api feature-request Request for new features or functionality
Milestone

Comments

@ghost
Copy link

ghost commented Dec 2, 2015

Is there a way to use wildcards in activationEvents.workspaceContains? i mean, could i do something like:

"activationEvents": [    
    "workspaceContains:*.config"
  ],
@alexdima alexdima self-assigned this Dec 3, 2015
@egamma egamma modified the milestone: Backlog Dec 10, 2015
@alexdima alexdima added feature-request Request for new features or functionality api labels Dec 11, 2015
@alexdima alexdima removed their assignment Aug 30, 2016
@akaroml
Copy link
Member

akaroml commented Jan 18, 2017

Just want to echo this feature request. We are developing an extension that should be triggered when there are *.ino files inside the workspace. This is obviously for Arduino and its source files do not necessarily have the same file names (could be anyname.ino).
So the wildcard support is exactly what we need.
By the way, the activationEvents:['*'] seems like an overkill for this.

@DustinCampbell
Copy link
Member

Yes, this is critical for C# in VS Code. We want to load on ".cs" and ".csproj" but can't do it without loading on "*". That's definitely overkill.

@enricosada
Copy link

Same for F# support with ionide-fsharp, is needed to load on ".fs" and ".fsproj" /cc @Krzysztof-Cieslak

@Krzysztof-Cieslak
Copy link
Contributor

From my point of view (and I guess similar is true for C# extension) to get really smooth startup experinace I'd need 2 things:

  1. Wildcards in activationEvents.workspaceContains
  2. activationEvents.workspaceContains checking also sub-directories not only top level folder.

alexdima added a commit that referenced this issue May 29, 2017
…ains

Fixes #944 - Support wildcards on activationEvents.workspaceContains
@alexdima alexdima modified the milestones: May 2017, Backlog May 29, 2017
@alexdima alexdima self-assigned this May 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

6 participants