Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to alt-click file paths beginning with \\?\ on Windows 10 #94961

Closed
connorskees opened this issue Apr 10, 2020 · 7 comments · Fixed by #95147
Closed

Unable to alt-click file paths beginning with \\?\ on Windows 10 #94961

connorskees opened this issue Apr 10, 2020 · 7 comments · Fixed by #95147
Assignees
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@connorskees
Copy link
Contributor

connorskees commented Apr 10, 2020

  • VSCode Version:
code-insiders --version
1.44.0-insider
ea935488ec0e5415d4205c1f33ba332fd417f85a
x64
  • OS Version: Microsoft Windows [Version 10.0.19592.1001]

Steps to Reproduce:

cd %userprofile% 
mkdir foo && cd foo
echo bar > baz
echo %userprofile%\foo\baz VS \\?\%userprofile%\foo\baz

When I hover the former in the integrated terminal, I am given the option to alt-click to follow the path, but this does not occur for the latter.

To verify that both paths are valid,

type %userprofile%\foo\baz
type \\?\%userprofile%\foo\baz

Does this issue occur when all extensions are disabled?: Yes

@RMacfarlane
Copy link
Contributor

@connorskees I assume you mean within the integrated terminal?

@connorskees
Copy link
Contributor Author

@RMacfarlane ah sorry for being unclear. Yes within the integrated terminal.

@Tyriar
Copy link
Member

Tyriar commented Apr 11, 2020

What does \\?\ mean?

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Apr 11, 2020
@connorskees
Copy link
Contributor Author

@Tyriar \\?\ allows for paths above 256 characters in length. The syntax also disables all string parsing on the path.

It is used by the Windows API in a few places, namely GetFinalPathNameByHandleA and CreateFileA. A few command line utilities I use use these functions to canonicalize paths.

@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues windows VS Code on Windows issues and removed info-needed Issue requires more information from poster labels Apr 11, 2020
@Tyriar Tyriar added this to the Backlog milestone Apr 11, 2020
@Tyriar
Copy link
Member

Tyriar commented Apr 11, 2020

Related: #21125

@connor4312
Copy link
Member

@Tyriar one thing I found is that the literal string \\?\%userprofile%\foo\baz is linkified, but clicking on it tries to open the workspace folder as a file and shows the error notification "Unable to open '': File is a directory.". Echoing and clicking on the real path, though, works fine.

@connor4312 connor4312 added the verified Verification succeeded label Apr 29, 2020
@Tyriar
Copy link
Member

Tyriar commented Apr 29, 2020

Nice find, it's being interpreted as a relative path.

@Tyriar Tyriar reopened this Apr 29, 2020
@Tyriar Tyriar removed the verified Verification succeeded label Apr 29, 2020
@Tyriar Tyriar closed this as completed in 507345d Apr 29, 2020
@connor4312 connor4312 added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants