Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle windows paths beginning with \\?\ #95147

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

connorskees
Copy link
Contributor

This should resolve #94961. It does so by optionally allowing drives to be prefixed by \\?\.

@Tyriar

@msftclas
Copy link

msftclas commented Apr 13, 2020

CLA assistant check
All CLA requirements met.

@connorskees connorskees changed the title handle windows paths beginning with \\?" handle windows paths beginning with \\?\ Apr 13, 2020
@connorskees
Copy link
Contributor Author

I'm having trouble replicating the CI errors locally. yarn run mocha --run src/vs/platform/backup/test/electron-main/backupMainService.test.ts says everything is fine, but in CI it timed out,

1) BackupMainService dedupeFolderWorkspaces should ignore duplicates on Windows and Mac (root workspace):
Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.

Should I just retry it?

@Tyriar
Copy link
Member

Tyriar commented Apr 14, 2020

Seems like a flake, also the ci.yml one can probably be ignored so this looks all good. Thanks for covering the new developments too with terminalValidatedLocalLinkProvider.test.ts 😄

@Tyriar Tyriar added this to the April 2020 milestone Apr 14, 2020
@Tyriar Tyriar merged commit 3d9f459 into microsoft:master Apr 14, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to alt-click file paths beginning with \\?\ on Windows 10
3 participants