-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: GitHub authentication for Git commands #96280
Comments
Works well on Windows. Some thoughts on this:
|
Actually, I think this is specifically addressed to those who have nothing configured. And those who do should not have their setup hijacked.
Yup, I had the same concerns... we'll just have to wait and see. ;) |
I had a few hiccups with the initial experience that need some polish. My hypothesis is that advanced users will already be logged in and won't experience this but newer users to VS Code and programming in general will likely hit this more. So if we're able to smooth out that experience I think it'll increase the odds of attaching them as active users. |
Refs: #96241, #96069
Complexity: 3
Communication with GitHub for the git features should now be handled automatically by VS Code.
Note: Please disable any credential manager you might have installed in your system by unsetting the
credential.helper
git config.Git: Clone
commandsGit: Pull
,Git: Push
andGit: Fetch
commandsAt no point in time should you be asked for credentials within VS Code, but instead go through the auth flow similar to the GitHub Pull Requests extension.
Additionally, the same auth integration should be working in the integrated terminal:
git clone
,git push
,git fetch
,git pull
should all work automatically without any prompt for credentials.Test that you can disable GitHub authentication with the
git.githubAuthentication
setting. Once disabled, you should get prompted for credentials in the quick open UI.Also test that you can disable the terminal integration with
git.terminalAuthentication
setting. Once disabled, quick open commands should work fine, but terminal shell commands should prompt for auth in the shell itself.The text was updated successfully, but these errors were encountered: