Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: GitHub authentication for Git commands #96280

Closed
3 tasks done
joaomoreno opened this issue Apr 27, 2020 · 3 comments
Closed
3 tasks done

Test: GitHub authentication for Git commands #96280

joaomoreno opened this issue Apr 27, 2020 · 3 comments

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Apr 27, 2020

Refs: #96241, #96069

Complexity: 3


Communication with GitHub for the git features should now be handled automatically by VS Code.

Note: Please disable any credential manager you might have installed in your system by unsetting the credential.helper git config.

  • Clone a private HTTPS repo with the Git: Clone commands
  • Use the Git: Pull, Git: Push and Git: Fetch commands

At no point in time should you be asked for credentials within VS Code, but instead go through the auth flow similar to the GitHub Pull Requests extension.

Additionally, the same auth integration should be working in the integrated terminal: git clone, git push, git fetch, git pull should all work automatically without any prompt for credentials.

Test that you can disable GitHub authentication with the git.githubAuthentication setting. Once disabled, you should get prompted for credentials in the quick open UI.

Also test that you can disable the terminal integration with git.terminalAuthentication setting. Once disabled, quick open commands should work fine, but terminal shell commands should prompt for auth in the shell itself.

@fiveisprime
Copy link
Member

fiveisprime commented Apr 28, 2020

Works well on Windows. Some thoughts on this:

  • The flow is fantastic: the command I run (both via command or terminal) continues after authenticating 💃
  • It seems unusual that customers would have credential helper unset. In that case, they'll see the GitHub auth modal instead - cancelling out of that triggers the GitHub extension
  • I'm not in love with the message "The extension 'Git' wants to sign in using GitHub." (especially when using the terminal) but I don't have a better suggestion. Are we confident that people will understand what that means?

@joaomoreno
Copy link
Member Author

It seems unusual that customers would have credential helper unset.

Actually, I think this is specifically addressed to those who have nothing configured. And those who do should not have their setup hijacked.

I'm not in love with the message "The extension 'Git' wants to sign in using GitHub." (especially when using the terminal) but I don't have a better suggestion. Are we confident that people will understand what that means?

Yup, I had the same concerns... we'll just have to wait and see. ;)

@miguelsolorio
Copy link
Contributor

I had a few hiccups with the initial experience that need some polish. My hypothesis is that advanced users will already be logged in and won't experience this but newer users to VS Code and programming in general will likely hit this more. So if we're able to smooth out that experience I think it'll increase the odds of attaching them as active users.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants