Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal links differ based on what cell is hovered first #97064

Closed
Tyriar opened this issue May 6, 2020 · 0 comments · Fixed by #97065
Closed

Terminal links differ based on what cell is hovered first #97064

Tyriar opened this issue May 6, 2020 · 0 comments · Fixed by #97065
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-links verified Verification succeeded
Milestone
May 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented May 6, 2020

Hovering > first:

image

Hovering other part first:

image

See: xtermjs/xterm.js#2848
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels May 6, 2020
@Tyriar Tyriar added this to the May 2020 milestone May 6, 2020
@Tyriar Tyriar self-assigned this May 6, 2020
@Tyriar Tyriar mentioned this issue May 6, 2020
Merged
Tyriar added a commit that referenced this issue May 6, 2020
@Tyriar
[email protected]
46e54a2 
Diff: xtermjs/xterm.js@f9adf8a...3a9cdba

Fixes #97064
@connor4312 connor4312 added the verified Verification succeeded label Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2020
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
[email protected]
d219bde 
Diff: xtermjs/xterm.js@f9adf8a...3a9cdba

Fixes microsoft#97064
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-links verified Verification succeeded
Projects
None yet
Milestone
May 2020
Development

Successfully merging a pull request may close this issue.

Adopt xterm provideLink -> provideLinks API change microsoft/vscode
2 participants
@Tyriar @connor4312