Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional languageId to window.createOutputChannel API (#19561) #140876

Merged
merged 4 commits into from
Feb 9, 2022

Conversation

gjsjohnmurray
Copy link
Contributor

This PR fixes #19561 by implementing proposed API which adds an optional languageId param to window.createOutputChannel.

This was previously suggested by @ArtemGovorov and was supported at the time by @jrieken.

It was later raised as a solution for #19561, opened by @formulahendry.

@gjsjohnmurray
Copy link
Contributor Author

@sandy081 any chance you could consider merging this in time for Monday's endgame?

@sandy081
Copy link
Member

I am sorry that I have to postpone this for the next milestone as this has to be discussed in our API sync meeting first. The last API sync for this milestone finished today and unfortunately I missed checking this in time. Since there is no urgency, I will plan this for next milestone and discuss in our API sync.

@sandy081 sandy081 added this to the February 2022 milestone Jan 19, 2022
@sandy081 sandy081 self-requested a review January 19, 2022 18:58
@gjsjohnmurray
Copy link
Contributor Author

@sandy081 no worries. I know you have been busy with other things.

@gjsjohnmurray
Copy link
Contributor Author

@sandy081 now that 1.64 has shipped, when will the next API sync meeting happen? I'd like to get this into Insiders soon.

@sandy081
Copy link
Member

sandy081 commented Feb 8, 2022

@gjsjohnmurray Thanks for reminding. API call is today. As per the process we will first add it to the proposed API and after getting some feedback we will finalize it. So most probably this will be a proposed API in this month and goes into finalization next month.

Copy link
Member

@sandy081 sandy081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Did some small clean ups. Approved.

@sandy081 sandy081 merged commit 4af4717 into microsoft:main Feb 9, 2022
@gjsjohnmurray gjsjohnmurray deleted the output-channel-language branch February 9, 2022 15:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to provide colorizers for specific output channels
4 participants