Accept capitalization in HTTP upgrade header in web #150961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinkar
force-pushed
the
capitalized-upgrade-header
branch
from
5bb7f87 to
05c412c
Compare
sandy081
approved these changes
Jun 1, 2022
4 tasks
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes VS Code web accept capitalization in HTTP upgrade header instead of only accepting
Upgrade: websocket.This solves a bug where the websocket connection fails with status 1006 when running VS Code web behind an Apache proxy that is using mod_proxy_wstunnel since mod_proxy_wstunnel sends the header
Upgrade: WebSocket.Relevant discussion about this bug can be found here.