Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codicons #152512

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Update codicons #152512

merged 1 commit into from
Jun 17, 2022

Conversation

miguelsolorio
Copy link
Contributor

cc @Tyriar @connor4312 @daviddossett

Update codicons
74a5461 
- Add `map` and `map-filled`
- Remap `debug-stackframe-dot` to `circle-small-filled`
- Add `circle-small`
microsoft/vscode-codicons@2b98cb8
@miguelsolorio miguelsolorio added this to the June 2022 milestone Jun 17, 2022
@miguelsolorio miguelsolorio enabled auto-merge (squash) June 17, 2022 19:55
@miguelsolorio miguelsolorio merged commit 187c93d into main Jun 17, 2022
@miguelsolorio miguelsolorio deleted the misolori/northern-puffin branch June 17, 2022 20:21
@Tyriar
Copy link
Member

Tyriar commented Jun 17, 2022

circle-small should be circle-small-outline for consistent naming?

@miguelsolorio
Copy link
Contributor Author

@Tyriar I'll be updating all of our names and using the outline version as the default and then adding filled for the solid ones, since the outline style is our default. Tracking under microsoft/vscode-codicons#117

@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joyceerhl joyceerhl joyceerhl approved these changes

Assignees

@miguelsolorio miguelsolorio

Labels
None yet
Projects
None yet
Milestone
June 2022
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelsolorio @Tyriar @joyceerhl